[GitHub] incubator-storm pull request: STORM-316: added validation to regis...

[revans2 <gi...@git.apache.org>]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/110#discussion_r12535229
  
    --- Diff: storm-core/src/jvm/backtype/storm/task/TopologyContext.java ---
    @@ -234,6 +234,11 @@ public void addTaskHook(ITaskHook hook) {
             if (metric == null) {
                 throw new IllegalArgumentException("Cannot register a null metric");
             }
    +
    +        if (timeBucketSizeInSecs <= 0) {
    +            throw new RuntimeException("TopologyContext.registerMetric can only be called with timeBucketSizeInSecs " +
    --- End diff --
    
    Could this be an IllegalArgumentException like the one above it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---