You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 18:59:12 UTC
[GitHub] [flink] austince opened a new pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
austince opened a new pull request #12185:
URL: https://github.com/apache/flink/pull/12185
## What is the purpose of the change
This PR allows users to override the RMQ source and sink connection setup, which supports lower-level features like [using a list of hosts](https://www.rabbitmq.com/api-guide.html#address-array) and [address resolution](https://www.rabbitmq.com/api-guide.html#service-discovery-with-address-resolver).
## Brief change log
- move the RMQSource connection setup to a protected class method
- move the RMQSink connection setup to a protected class method
## Verifying this change
This change added tests and can be verified as follows:
- Added `RMQSourceTest#testOverrideConnection`, which overrides a mock source with a mock connection
- Added `RMQSinkTest#testOverrideConnection`, which does the same
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629434033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 622f3c894f66735cb2be082dcaed838dbde494b9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] austince commented on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
austince commented on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629523076
@flinkbot run azure :pray:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629426422
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f2c27e8d19db94e6c57ed5437db3dda01d3fd143 (Fri Oct 16 10:33:26 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] asfgit closed pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #12185:
URL: https://github.com/apache/flink/pull/12185
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629434033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1474",
"triggerID" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"triggerType" : "PUSH"
}, {
"hash" : "f2c27e8d19db94e6c57ed5437db3dda01d3fd143",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1479",
"triggerID" : "f2c27e8d19db94e6c57ed5437db3dda01d3fd143",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 622f3c894f66735cb2be082dcaed838dbde494b9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1474)
* f2c27e8d19db94e6c57ed5437db3dda01d3fd143 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] austince commented on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
austince commented on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629426165
@senegalo, hope you're feeling better - let me know what you think if you have a chance!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629434033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1474",
"triggerID" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 622f3c894f66735cb2be082dcaed838dbde494b9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1474)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629692237
Thanks! The change looks good to me.
Merging this...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629434033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1474",
"triggerID" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"triggerType" : "PUSH"
}, {
"hash" : "f2c27e8d19db94e6c57ed5437db3dda01d3fd143",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1479",
"triggerID" : "f2c27e8d19db94e6c57ed5437db3dda01d3fd143",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2c27e8d19db94e6c57ed5437db3dda01d3fd143 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] senegalo commented on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
senegalo commented on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629628101
@austince i feel much better :) thanks for asking
and i like the change instead of having to override the whole open you just override this tiny small method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629434033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1474",
"triggerID" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"triggerType" : "PUSH"
}, {
"hash" : "f2c27e8d19db94e6c57ed5437db3dda01d3fd143",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f2c27e8d19db94e6c57ed5437db3dda01d3fd143",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 622f3c894f66735cb2be082dcaed838dbde494b9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1474)
* f2c27e8d19db94e6c57ed5437db3dda01d3fd143 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629426422
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 622f3c894f66735cb2be082dcaed838dbde494b9 (Fri May 15 19:01:57 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-7267).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12185:
URL: https://github.com/apache/flink/pull/12185#issuecomment-629434033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1474",
"triggerID" : "622f3c894f66735cb2be082dcaed838dbde494b9",
"triggerType" : "PUSH"
}, {
"hash" : "f2c27e8d19db94e6c57ed5437db3dda01d3fd143",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1479",
"triggerID" : "f2c27e8d19db94e6c57ed5437db3dda01d3fd143",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 622f3c894f66735cb2be082dcaed838dbde494b9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1474)
* f2c27e8d19db94e6c57ed5437db3dda01d3fd143 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org