You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ko...@apache.org on 2015/10/01 23:47:43 UTC
svn commit: r1706323 -
/subversion/trunk/subversion/libsvn_ra_serf/multistatus.c
Author: kotkov
Date: Thu Oct 1 21:47:42 2015
New Revision: 1706323
URL: http://svn.apache.org/viewvc?rev=1706323&view=rev
Log:
Remove a bit of unneeded code from libsvn_ra_serf's multistatus parser.
Responses on request failures consist of a single <D:error> element and do
not contain a response description (<D:responsedescription>). Hence, there
is no need to check if we have one when closing the <D:error> tag in the
transitional parser.
An example of such response:
<?xml version="1.0" encoding="utf-8"?>
<D:error [...]>
<C:error/>
<m:human-readable errcode="160013">
File not found: transaction '1-1', path '/A'
</m:human-readable>
</D:error>
* subversion/libsvn_ra_serf/multistatus.c
(multistatus_closed): Remove the unnecessary else clause within the
D_ERROR state handling.
Modified:
subversion/trunk/subversion/libsvn_ra_serf/multistatus.c
Modified: subversion/trunk/subversion/libsvn_ra_serf/multistatus.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/multistatus.c?rev=1706323&r1=1706322&r2=1706323&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/multistatus.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/multistatus.c Thu Oct 1 21:47:42 2015
@@ -442,9 +442,6 @@ multistatus_closed(svn_ra_serf__xml_esta
item->message = apr_pstrdup(server_error->pool, item->message);
}
- else
- item->message = apr_pstrdup(server_error->pool,
- svn_hash_gets(attrs, "description"));
APR_ARRAY_PUSH(server_error->items, error_item_t *) = item;