You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Commit Tag Bot (JIRA)" <ji...@apache.org> on 2013/06/13 08:48:20 UTC

[jira] [Commented] (SOLR-4920) DIH JdbcDataSource exception handling

    [ https://issues.apache.org/jira/browse/SOLR-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681960#comment-13681960 ] 

Commit Tag Bot commented on SOLR-4920:
--------------------------------------

[trunk commit] shalin
http://svn.apache.org/viewvc?view=revision&revision=1492537

SOLR-4920: JdbcDataSource incorrectly suppresses exceptions when retrieving a connection from  a JNDI context and falls back to trying to use DriverManager to obtain a connection. Additionally,  if a SQLException is thrown while initializing a connection, such as in setAutoCommit(), the  connection will not be closed.
                
> DIH JdbcDataSource exception handling
> -------------------------------------
>
>                 Key: SOLR-4920
>                 URL: https://issues.apache.org/jira/browse/SOLR-4920
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.3, 5.0
>            Reporter: Chris Eldredge
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>         Attachments: patch.diff
>
>
> JdbcDataSource will incorrectly suppress exceptions when retrieving a connection from a JNDI context and fall back to trying to use DriverManager to obtain a connection. This makes it impossible to troubleshoot misconfigured JNDI DataSource.
> Additionally, when a SQLException is thrown while initializing a connection, such as in setAutoCommit(), the connection will not be closed. This can cause a resource leak.
> A patch will be attached with unit tests that addresses both issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org