You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2017/12/06 11:48:00 UTC
[GitHub] spark pull request #19909: [SPARK-22697][SQL] GenerateMutableProjection shou...
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/19909
[SPARK-22697][SQL] GenerateMutableProjection should not create unneeded global variables
## What changes were proposed in this pull request?
GenerateMutableProjection is using global variables which are not needed. This can generate many unneeded entries in the constant pool.
The PR removes the unnecessary mutable states and makes them local variables.
## How was this patch tested?
added UT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/spark SPARK-22697
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19909
----
commit d3bebce3ba72b184c8b29e256ab6ca432a7ee246
Author: Marco Gaido <mg...@hortonworks.com>
Date: 2017-12-06T11:35:36Z
[SPARK-22697][SQL] GenerateMutableProjection should not create unneeded global variables
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19909: [SPARK-22697][SQL] GenerateMutableProjection shou...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 closed the pull request at:
https://github.com/apache/spark/pull/19909
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19909: [SPARK-22697][SQL] GenerateMutableProjection should not ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19909
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84550/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19909: [SPARK-22697][SQL] GenerateMutableProjection should not ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19909
**[Test build #84550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84550/testReport)** for PR 19909 at commit [`d3bebce`](https://github.com/apache/spark/commit/d3bebce3ba72b184c8b29e256ab6ca432a7ee246).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19909: [SPARK-22697][SQL] GenerateMutableProjection should not ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19909
**[Test build #84550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84550/testReport)** for PR 19909 at commit [`d3bebce`](https://github.com/apache/spark/commit/d3bebce3ba72b184c8b29e256ab6ca432a7ee246).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` |class SpecificMutableProjection extends $`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19909: [SPARK-22697][SQL] GenerateMutableProjection should not ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19909
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19909: [SPARK-22697][SQL] GenerateMutableProjection should not ...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19909
Unfortunately all the solution require using another row. Since this might not be as performant as the current code I am closing this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org