You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/09 16:09:36 UTC
[GitHub] [spark] LuciferYang commented on a diff in pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
LuciferYang commented on code in PR #37842:
URL: https://github.com/apache/spark/pull/37842#discussion_r967243275
##########
pom.xml:
##########
@@ -1139,37 +1139,38 @@
<dependency>
<groupId>org.scalatest</groupId>
<artifactId>scalatest_${scala.binary.version}</artifactId>
- <version>3.3.0-SNAP3</version>
+ <version>3.2.13</version>
Review Comment:
Not downgrade:
1. https://search.maven.org/artifact/org.scalatest/scalatest_2.12
<img width="977" alt="image" src="https://user-images.githubusercontent.com/1475305/189393708-d31defe2-08ea-41e5-956f-21548cc72773.png">
The update time of `3.3.0-SNAP3` is 11-Dec-2020, this is earlier than the release of 3.2.4
2. https://github.com/scalatest/scalatest/tags
There is no 3.3.x officially tag and it seems that the 3.3.x branch is still under development or has been abandoned(The latest commit was 16 Mar)
So I don't think we should use this version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org