[GitHub] [solr] NazerkeBS commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json

[GitBox <gi...@apache.org>]

NazerkeBS commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r784824339



##########
File path: solr/core/src/test/org/apache/solr/handler/admin/PropertiesRequestHandlerTest.java
##########
@@ -62,13 +61,9 @@ public void testDisabledRedaction() throws Exception {
 
   @SuppressWarnings({"unchecked"})
   private NamedList<Object> readProperties() throws Exception {
-    String xml = h.query(req(
-        CommonParams.QT, "/admin/properties",
-        CommonParams.WT, "xml"
-    ));
-
-    XMLResponseParser parser = new XMLResponseParser();
-    return (NamedList<Object>)
-        parser.processResponse(new StringReader(xml)).get("system.properties");
+    SolrQueryResponse rsp = new SolrQueryResponse();
+    SolrQueryRequest req = req();
+    new PropertiesRequestHandler().handleRequestBody(req, rsp);

Review comment:
       I had a look if there is a replacement for `qt=/admin/properties` to check the path accessibility, but couldn't find one. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org