[jira] [Commented] (WAGON-543) wagon-ssh download hangs

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WAGON-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732174#comment-16732174 ] 

Michael Osipov commented on WAGON-543:
--------------------------------------

[~dantran], I believe the current code does not hav a bug, but simply surfaced a bug in the {{InputStream}} implementation of JSch. {{#read()}} is not implemented as specified and does not return a -1 on EOF.

The fundamental difference is that the previous code request to stream the only remaining amount of bytes and the new one the at most the amount of bytes available to the buffer which is more than 916,

> wagon-ssh download hangs
> ------------------------
>
>                 Key: WAGON-543
>                 URL: https://issues.apache.org/jira/browse/WAGON-543
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-ssh
>    Affects Versions: 3.3.0
>            Reporter: Dan Tran
>            Assignee: Michael Osipov
>            Priority: Major
>
> To reproduce this issue
>   1. checkout https://github.com/mojohaus/wagon-maven-plugin.git
>   2. Locally build maven 3.6.1-SNAPSHOT with wagon 3.3.0 and run it with
>   3. cd src/test/project/ssh-it; mvn -Dit-plugin.version=2.0.0
> Assume your local account can ssh to same host with ssh key
> other notes:
>   * No problem with maven 3.6.0
>   * I also have internal ssh library wrapper of wagon-ssh to perform sshexe/upload/download activities.  Seeing the same issue with  wagon 3.3.0
>   * The root cause likely is from WAGON-537  with changes at AbstractWagon which may have side effect on internal JSCH 32K buffer
> Reverting WAGON-537 fixes this issue



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)