You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2016/07/01 12:56:57 UTC
Re: Review Request 49441: ATLAS-968 - Set group information from UGI
for Ldap authentication.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49441/
-----------------------------------------------------------
(Updated July 1, 2016, 12:56 p.m.)
Review request for atlas, Madhan Neethiraj, Mehul Parikh, Shwetha GS, and Hemanth Yamijala.
Changes
-------
Changes include changes for setting groups information from UGI for LDAP/AD type.
Added atlas.authentication.method.ldap.ugi-groups property for UGI group.
Bugs: ATLAS-968
https://issues.apache.org/jira/browse/ATLAS-968
Repository: atlas
Description
-------
The patch includes changes for setting groups information from UGI in ldap type in which group information is not retrived from ldap directory.
Diffs (updated)
-----
distro/src/conf/atlas-application.properties cc0e4c1
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java cf83109
webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java 5f1a245
webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6d56453
Diff: https://reviews.apache.org/r/49441/diff/
Testing
-------
ran mvn clean install
created user in ldap ambari-qa which has groups associated in UGI and logged in with it. groups retrived from UGI were proper. http://172.22.89.116:21000/api/atlas/admin/session {"userName":"ambari-qa","groups":["hadoop","users"]}
logged in with user ldapuser11 and no groups were set from UGI.
http://172.22.89.116:21000/api/atlas/admin/session {"userName":"ldapuser11","groups":[]}
Thanks,
Nixon Rodrigues
Re: Review Request 49441: ATLAS-968 - Set group information from UGI
for Ldap authentication.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49441/#review140959
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 4, 2016, 7:15 a.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49441/
> -----------------------------------------------------------
>
> (Updated July 4, 2016, 7:15 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Mehul Parikh, Shwetha GS, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-968
> https://issues.apache.org/jira/browse/ATLAS-968
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The patch includes changes for setting groups information from UGI in ldap type in which group information is not retrived from ldap directory.
>
>
> Diffs
> -----
>
> distro/src/conf/atlas-application.properties cc0e4c1
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java cf83109
> webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java 5f1a245
> webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6d56453
>
> Diff: https://reviews.apache.org/r/49441/diff/
>
>
> Testing
> -------
>
> ran mvn clean install
>
> created user in ldap ambari-qa which has groups associated in UGI and logged in with it. groups retrived from UGI were proper. http://172.22.89.116:21000/api/atlas/admin/session {"userName":"ambari-qa","groups":["hadoop","users"]}
>
> logged in with user ldapuser11 and no groups were set from UGI.
> http://172.22.89.116:21000/api/atlas/admin/session {"userName":"ldapuser11","groups":[]}
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 49441: ATLAS-968 - Set group information from UGI
for Ldap authentication.
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49441/
-----------------------------------------------------------
(Updated July 4, 2016, 7:15 a.m.)
Review request for atlas, Madhan Neethiraj, Mehul Parikh, Shwetha GS, and Hemanth Yamijala.
Changes
-------
The patch includes changes done to handle review comments.
Bugs: ATLAS-968
https://issues.apache.org/jira/browse/ATLAS-968
Repository: atlas
Description
-------
The patch includes changes for setting groups information from UGI in ldap type in which group information is not retrived from ldap directory.
Diffs (updated)
-----
distro/src/conf/atlas-application.properties cc0e4c1
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java cf83109
webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java 5f1a245
webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6d56453
Diff: https://reviews.apache.org/r/49441/diff/
Testing
-------
ran mvn clean install
created user in ldap ambari-qa which has groups associated in UGI and logged in with it. groups retrived from UGI were proper. http://172.22.89.116:21000/api/atlas/admin/session {"userName":"ambari-qa","groups":["hadoop","users"]}
logged in with user ldapuser11 and no groups were set from UGI.
http://172.22.89.116:21000/api/atlas/admin/session {"userName":"ldapuser11","groups":[]}
Thanks,
Nixon Rodrigues
Re: Review Request 49441: ATLAS-968 - Set group information from UGI
for Ldap authentication.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49441/#review140423
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java (line 116)
<https://reviews.apache.org/r/49441/#comment205824>
the default should be to get the user-groups from UserGroupInformation. Please review the default value.
webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java (line 97)
<https://reviews.apache.org/r/49441/#comment205822>
handle the following cases:
- ugi is null
- userGroups is null
webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java (line 148)
<https://reviews.apache.org/r/49441/#comment205823>
the default should be to get the user-groups from UserGroupInformation. Please review the default value.
- Madhan Neethiraj
On July 1, 2016, 12:56 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49441/
> -----------------------------------------------------------
>
> (Updated July 1, 2016, 12:56 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Mehul Parikh, Shwetha GS, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-968
> https://issues.apache.org/jira/browse/ATLAS-968
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The patch includes changes for setting groups information from UGI in ldap type in which group information is not retrived from ldap directory.
>
>
> Diffs
> -----
>
> distro/src/conf/atlas-application.properties cc0e4c1
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java cf83109
> webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java 5f1a245
> webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6d56453
>
> Diff: https://reviews.apache.org/r/49441/diff/
>
>
> Testing
> -------
>
> ran mvn clean install
>
> created user in ldap ambari-qa which has groups associated in UGI and logged in with it. groups retrived from UGI were proper. http://172.22.89.116:21000/api/atlas/admin/session {"userName":"ambari-qa","groups":["hadoop","users"]}
>
> logged in with user ldapuser11 and no groups were set from UGI.
> http://172.22.89.116:21000/api/atlas/admin/session {"userName":"ldapuser11","groups":[]}
>
>
> Thanks,
>
> Nixon Rodrigues
>
>