You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/25 01:57:21 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #5554: [HUDI-4082][HUDI-FLINK]enhance the readability of hudi operator names…

danny0405 commented on code in PR #5554:
URL: https://github.com/apache/hudi/pull/5554#discussion_r881137895


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -315,14 +315,14 @@ public static DataStream<HoodieRecord> rowDataToHoodieRecord(Configuration conf,
    * @param dataStream         The input data stream
    * @return the stream write data stream pipeline
    */
-  public static DataStream<Object> hoodieStreamWrite(Configuration conf, int defaultParallelism, DataStream<HoodieRecord> dataStream) {
+  public static DataStream<Object> hoodieStreamWrite(Configuration conf, int defaultParallelism, DataStream<HoodieRecord> dataStream, String sinkOperatorNameSuffix) {
     if (OptionsResolver.isBucketIndexType(conf)) {

Review Comment:
   The `sinkOperatorNameSuffix` can be resolved in the `conf`, there is no need to pass it around explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org