You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/09 14:42:20 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #10956: Fully support running more than one scheduler concurrently

mik-laj commented on a change in pull request #10956:
URL: https://github.com/apache/airflow/pull/10956#discussion_r502475807



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -303,10 +303,10 @@ def done(self) -> bool:
         return False
 
     @property
-    def result(self) -> Optional[Tuple[List[dict], int]]:
+    def result(self) -> Optional[int]:
         """
         :return: result of running SchedulerJob.process_file()
-        :rtype: Optional[Tuple[List[dict], int]]
+        :rtype: int or None

Review comment:
       This function returns tuple or None. The description in the pydocstring is incorrect.
   `int or None` != `Optional[Tuple[int, int]]`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org