[GitHub] [skywalking-python] kezhenxu94 commented on a diff in pull request #288: Add prefork support for uwsgi and gunicorn

["kezhenxu94 (via GitHub)" <gi...@apache.org>]

kezhenxu94 commented on code in PR #288:
URL: https://github.com/apache/skywalking-python/pull/288#discussion_r1110455128


##########
demo/docker-compose.yaml:
##########
@@ -55,37 +55,37 @@ services:
     environment:
       SW_OAP_ADDRESS: "http://oap:12800"
 
-  zookeeper:
-    container_name: zk
-    image: confluentinc/cp-zookeeper:latest
-    ports:
-      - "2181:2181"
-    environment:
-      ZOOKEEPER_CLIENT_PORT: 2181
-      ZOOKEEPER_TICK_TIME: 2000
-    networks:
-      - manual
-
-  kafka:
-    container_name: kafka
-    image: confluentinc/cp-kafka
-    expose:
-      - 9092
-      - 9094
-    ports:
-      - 9092:9092
-      - 9094:9094
-    depends_on:
-      - zookeeper
-    environment:
-      KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
-      KAFKA_LISTENERS: INTERNAL://0.0.0.0:9092,OUTSIDE://0.0.0.0:9094
-      KAFKA_ADVERTISED_LISTENERS: INTERNAL://kafka:9092,OUTSIDE://localhost:9094
-      KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: INTERNAL:PLAINTEXT,OUTSIDE:PLAINTEXT
-      KAFKA_INTER_BROKER_LISTENER_NAME: INTERNAL
-      KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
-    networks:
-      - manual
+#  zookeeper:

Review Comment:
   And this. Please also check the other places, I didn't point out all commented places. 



##########
demo/docker-compose.yaml:
##########
@@ -38,8 +38,8 @@ services:
     ports:
       - "12800:12800"
       - "11800:11800"
-    depends_on:
-      - kafka
+#    depends_on:
+#      - kafka

Review Comment:
   And this



##########
demo/docker-compose.yaml:
##########
@@ -25,11 +25,11 @@ services:
       - 12800 # HTTP
     networks:
       - manual
-    environment:
-      SW_KAFKA_FETCHER: default
-      SW_KAFKA_FETCHER_SERVERS: kafka:9092
-      SW_KAFKA_FETCHER_PARTITIONS: 2
-      SW_KAFKA_FETCHER_PARTITIONS_FACTOR: 1
+#    environment:
+#      SW_KAFKA_FETCHER: default
+#      SW_KAFKA_FETCHER_SERVERS: kafka:9092
+#      SW_KAFKA_FETCHER_PARTITIONS: 2
+#      SW_KAFKA_FETCHER_PARTITIONS_FACTOR: 1

Review Comment:
   Remove these?



##########
CHANGELOG.md:
##########
@@ -8,7 +8,8 @@
   please check with the latest official documentation before upgrading. (#273, #282)
   https://skywalking.apache.org/docs/skywalking-python/v1.0.0/en/setup/configuration/
   - **BREAKING**: All agent core capabilities are now covered by test cases and enabled by default (Trace, Log, PVM runtime metrics, Profiler)
-
+  - **BREAKING**: DockerHub Python agent images since v1.0.0 will no longer include the `run` part in `ENTRYPOINT ["sw-python", "run"]`, 
+  user should prefix their command with `[-d/--debug] run [-p/--prefork] <Command>` for extra flexibility.

Review Comment:
   This is not true according to what we discussed yesterday and the code in this pr 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org