You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/09/27 18:46:57 UTC
[GitHub] [gobblin] codecov-commenter commented on pull request #3404: [GOBBLIN-1457] Lazy-load issues to improve performance

codecov-commenter commented on pull request #3404:
URL: https://github.com/apache/gobblin/pull/3404#issuecomment-928173794


   # [Codecov](https://codecov.io/gh/apache/gobblin/pull/3404?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3404](https://codecov.io/gh/apache/gobblin/pull/3404?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5bc8d01) into [master](https://codecov.io/gh/apache/gobblin/commit/2abda8679d9ce1045f6c7855d58d0b10b585f8e6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2abda86) will **decrease** coverage by `3.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/gobblin/pull/3404/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/gobblin/pull/3404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3404      +/-   ##
   ============================================
   - Coverage     46.53%   43.34%   -3.20%     
   + Complexity    10245     2007    -8238     
   ============================================
     Files          2063      401    -1662     
     Lines         80462    17187   -63275     
     Branches       8988     2115    -6873     
   ============================================
   - Hits          37443     7449   -29994     
   + Misses        39550     8901   -30649     
   + Partials       3469      837    -2632     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../gobblin/runtime/util/JobStateToJsonConverter.java](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9Kb2JTdGF0ZVRvSnNvbkNvbnZlcnRlci5qYXZh) | | |
   | [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | | |
   | [...onverter/parquet/JsonElementConversionFactory.java](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb252ZXJ0ZXIvcGFycXVldC9Kc29uRWxlbWVudENvbnZlcnNpb25GYWN0b3J5LmphdmE=) | | |
   | [.../apache/gobblin/runtime/DefaultLimiterFactory.java](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvRGVmYXVsdExpbWl0ZXJGYWN0b3J5LmphdmE=) | | |
   | [...apache/gobblin/writer/RecordTooLargeException.java](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1JlY29yZFRvb0xhcmdlRXhjZXB0aW9uLmphdmE=) | | |
   | [...apache/gobblin/runtime/api/JobCatalogListener.java](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkNhdGFsb2dMaXN0ZW5lci5qYXZh) | | |
   | [...he/gobblin/policies/count/RowCountRangePolicy.java](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3BvbGljaWVzL2NvdW50L1Jvd0NvdW50UmFuZ2VQb2xpY3kuamF2YQ==) | | |
   | [...che/gobblin/util/ReflectivePredicateEvaluator.java](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvUmVmbGVjdGl2ZVByZWRpY2F0ZUV2YWx1YXRvci5qYXZh) | | |
   | [...lin/source/extractor/extract/kafka/KafkaUtils.java](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVV0aWxzLmphdmE=) | | |
   | [.../apache/gobblin/runtime/StreamModelTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU3RyZWFtTW9kZWxUYXNrUnVubmVyLmphdmE=) | | |
   | ... and [1648 more](https://codecov.io/gh/apache/gobblin/pull/3404/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3404?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3404?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2abda86...5bc8d01](https://codecov.io/gh/apache/gobblin/pull/3404?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org