You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Deepak Barr <de...@gmail.com> on 2015/11/25 19:04:27 UTC

Review Request 40714: LENS-883 : httpresultset api should return 404 when resultset file does not exist

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40714/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-883
    https://issues.apache.org/jira/browse/LENS-883


Repository: lens


Description
-------

Earlier, In case the result file is purged by QueryResultPurger, /httpresultset api returned 500. It will return 404.


Diffs
-----

  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 941b1e5 

Diff: https://reviews.apache.org/r/40714/diff/


Testing
-------

Yes.


[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [  2.394 s]
[INFO] Lens ............................................... SUCCESS [  4.981 s]
[INFO] Lens API ........................................... SUCCESS [ 23.560 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 18.294 s]
[INFO] Lens Cube .......................................... SUCCESS [05:53 min]
[INFO] Lens DB storage .................................... SUCCESS [ 30.783 s]
[INFO] Lens Query Library ................................. SUCCESS [ 13.830 s]
[INFO] Lens Hive Driver ................................... SUCCESS [03:52 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [01:13 min]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.990 s]
[INFO] Lens Server ........................................ SUCCESS [13:23 min]
[INFO] Lens client ........................................ SUCCESS [ 46.292 s]
[INFO] Lens CLI ........................................... SUCCESS [ 53.935 s]
[INFO] Lens Examples ...................................... SUCCESS [  8.876 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  2.099 s]
[INFO] Lens Distribution .................................. SUCCESS [ 10.968 s]
[INFO] Lens ML Lib ........................................ SUCCESS [02:04 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [  2.767 s]
[INFO] Lens Regression .................................... SUCCESS [ 13.184 s]
[INFO] Lens UI ............................................ SUCCESS [  3.619 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:38 min
[INFO] Finished at: 2015-11-25T23:26:52+05:30
[INFO] Final Memory: 144M/841M
[INFO] ------------------------------------------------------------------------


Thanks,

Deepak Barr


Re: Review Request 40714: LENS-883 : httpresultset api should return 404 when resultset file does not exist

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40714/#review108089
-----------------------------------------------------------

Ship it!


Ship It!

- Rajat Khandelwal


On Nov. 25, 2015, 11:34 p.m., Deepak Barr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40714/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 11:34 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-883
>     https://issues.apache.org/jira/browse/LENS-883
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Earlier, In case the result file is purged by QueryResultPurger, /httpresultset api returned 500. It will return 404.
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 941b1e5 
> 
> Diff: https://reviews.apache.org/r/40714/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  2.394 s]
> [INFO] Lens ............................................... SUCCESS [  4.981 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.560 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 18.294 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:53 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 30.783 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 13.830 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [03:52 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [01:13 min]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.990 s]
> [INFO] Lens Server ........................................ SUCCESS [13:23 min]
> [INFO] Lens client ........................................ SUCCESS [ 46.292 s]
> [INFO] Lens CLI ........................................... SUCCESS [ 53.935 s]
> [INFO] Lens Examples ...................................... SUCCESS [  8.876 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  2.099 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 10.968 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:04 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  2.767 s]
> [INFO] Lens Regression .................................... SUCCESS [ 13.184 s]
> [INFO] Lens UI ............................................ SUCCESS [  3.619 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:38 min
> [INFO] Finished at: 2015-11-25T23:26:52+05:30
> [INFO] Final Memory: 144M/841M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>