You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "howarle (via GitHub)" <gi...@apache.org> on 2024/07/03 11:02:50 UTC
[PR] fix bug: switch between stream_rpc and baidu_std (brpc)
howarle opened a new pull request, #2678:
URL: https://github.com/apache/brpc/pull/2678
### What problem does this PR solve?
Issue Number: https://github.com/apache/brpc/issues/2677
Problem Summary: under `baidu_std`, server can not parse message when normal PRC and stream RPC arrive simultaneously
### What is changed and the side effects?
Changed: switch between `baidu_std` and `stream_rpc` in `InputMessenger::CutInputMessage`
Side effects:
- Performance effects(性能影响): Little or none
- Breaking backward compatibility(向后兼容性): no
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix bug: switch between stream_rpc and baidu_std (brpc)
Posted by "Huixxi (via GitHub)" <gi...@apache.org>.
Huixxi merged PR #2678:
URL: https://github.com/apache/brpc/pull/2678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix bug: switch between stream_rpc and baidu_std (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2678:
URL: https://github.com/apache/brpc/pull/2678#issuecomment-2207975487
UT failed：
```
brpc_streaming_rpc_unittest.cpp:254: Failure
Expected equality of these values:
0
brpc::StreamWrite(request_stream, out)
Which is: 11
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix bug: switch between stream_rpc and baidu_std (brpc)
Posted by "howarle (via GitHub)" <gi...@apache.org>.
howarle commented on PR #2678:
URL: https://github.com/apache/brpc/pull/2678#issuecomment-2209903783
这个似乎是UT的概率fail问题，main上的UT也是fail的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix bug: switch between stream_rpc and baidu_std (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2678:
URL: https://github.com/apache/brpc/pull/2678#issuecomment-2211691354
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org