You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/04 18:34:35 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4671: Make
GenericRow support null value fields and default null values
codecov-io commented on issue #4671: Make GenericRow support null value fields and default null values
URL: https://github.com/apache/incubator-pinot/pull/4671#issuecomment-538513277
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4671?src=pr&el=h1) Report
> Merging [#4671](https://codecov.io/gh/apache/incubator-pinot/pull/4671?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/bed6efec8abd8e461927950513ec849e4ab071c2?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `79.59%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4671 +/- ##
============================================
- Coverage 64.66% 64.58% -0.09%
Complexity 16 16
============================================
Files 1056 1056
Lines 56192 56198 +6
Branches 8331 8332 +1
============================================
- Hits 36338 36294 -44
- Misses 17160 17221 +61
+ Partials 2694 2683 -11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/pinot/core/data/readers/RecordReaderUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUmVjb3JkUmVhZGVyVXRpbHMuamF2YQ==) | `81.6% <ø> (-1%)` | `0 <0> (ø)` | |
| [...inot/core/data/readers/GenericRowRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvR2VuZXJpY1Jvd1JlY29yZFJlYWRlci5qYXZh) | `93.33% <100%> (-0.79%)` | `0 <0> (ø)` | |
| [...data/readers/MultiplePinotSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvTXVsdGlwbGVQaW5vdFNlZ21lbnRSZWNvcmRSZWFkZXIuamF2YQ==) | `72.22% <100%> (-0.51%)` | `0 <0> (ø)` | |
| [...e/data/recordtransformer/CompositeTransformer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlY29yZHRyYW5zZm9ybWVyL0NvbXBvc2l0ZVRyYW5zZm9ybWVyLmphdmE=) | `83.33% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ata/recordtransformer/SanitizationTransformer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlY29yZHRyYW5zZm9ybWVyL1Nhbml0aXphdGlvblRyYW5zZm9ybWVyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pinot/core/minion/segment/ReducerRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vc2VnbWVudC9SZWR1Y2VyUmVjb3JkUmVhZGVyLmphdmE=) | `90.19% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...t/creator/impl/SegmentIndexCreationDriverImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50SW5kZXhDcmVhdGlvbkRyaXZlckltcGwuamF2YQ==) | `89.71% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/data/recordtransformer/NullValueTransformer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlY29yZHRyYW5zZm9ybWVyL051bGxWYWx1ZVRyYW5zZm9ybWVyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/pinot/core/minion/SegmentPurger.java](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vU2VnbWVudFB1cmdlci5qYXZh) | `77.41% <100%> (-0.48%)` | `0 <0> (ø)` | |
| [.../pinot/core/minion/segment/MapperRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vc2VnbWVudC9NYXBwZXJSZWNvcmRSZWFkZXIuamF2YQ==) | `81.08% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/incubator-pinot/pull/4671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4671?src=pr&el=footer). Last update [bed6efe...24c87c2](https://codecov.io/gh/apache/incubator-pinot/pull/4671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org