You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Mike Drob (Jira)" <ji...@apache.org> on 2020/06/22 15:43:00 UTC
[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache
should not use a SolrCore as key
[ https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142196#comment-17142196 ]
Mike Drob commented on SOLR-14576:
----------------------------------
Do you have GC logs or a heap dump analysis highlighting it? I'd be interested to learn more.
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -----------------------------------------------------------------
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Noble Paul
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can make it
> {code}
> private static WeakIdentityMap<String, EtagCacheVal> etagCoreCache = WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap<SolrCore, EtagCacheVal> etagCoreCache = WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org