You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/24 06:15:13 UTC

[GitHub] [spark] Peng-Lei opened a new pull request #33051: Add test for multi and divide of year month interval of any fields

Peng-Lei opened a new pull request #33051:
URL: https://github.com/apache/spark/pull/33051


   ### What changes were proposed in this pull request?
   Check multiply/divide of year-month intervals of any fields by numeric
   
   ### Why are the changes needed?
   [SPARK-35778](https://issues.apache.org/jira/browse/SPARK-35778)
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Expanded existed test cases
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33051: [SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields by numeric

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33051:
URL: https://github.com/apache/spark/pull/33051#issuecomment-867540510


   > @AngersZhuuuu @Peng-Lei How about this #33014 . Is it wrong too?
   
   Yes, In #33056 I have ignore these two pr's change, and after merge #33056, we will raise follow up to revert current wrong change and add correct UT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Peng-Lei commented on pull request #33051: [SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields by numeric

Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on pull request #33051:
URL: https://github.com/apache/spark/pull/33051#issuecomment-867638255


   > @Peng-Lei Next time, let's add checks for year-month and day-time interval types in one PR.
   
   @MaxGekk OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #33051: [SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields by numeric

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33051:
URL: https://github.com/apache/spark/pull/33051#issuecomment-867552098


   @Peng-Lei Next time, let's add checks for year-month and day-time interval types in one PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33051: [SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields by numeric

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33051:
URL: https://github.com/apache/spark/pull/33051#issuecomment-867505448


   @MaxGekk this pr is wrong according to https://github.com/apache/spark/pull/33056 ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #33051: [SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields by numeric

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33051:
URL: https://github.com/apache/spark/pull/33051#issuecomment-867535608


   @AngersZhuuuu @Peng-Lei How about this https://github.com/apache/spark/pull/33014 . Is it wrong too?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #33051: [SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields by numeric

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33051:
URL: https://github.com/apache/spark/pull/33051#issuecomment-867551162


   Here are 2 reverts:
   1. https://github.com/apache/spark/pull/33060
   2. https://github.com/apache/spark/pull/33059
   
   @cloud-fan @HyukjinKwon @sarutak May I ask you to approve them, please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Peng-Lei commented on pull request #33051: [SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields by numeric

Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on pull request #33051:
URL: https://github.com/apache/spark/pull/33051#issuecomment-867527367


   > @MaxGekk this pr is wrong according to #33056 ...
   
   
   
   > @MaxGekk this pr is wrong according to #33056 ...
   
   I also think when the same Period convert to different year month interval should be different value to store. So I also think the PR is wrong. we should wait the another PR,then rewite this PR change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33051: [SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33051:
URL: https://github.com/apache/spark/pull/33051#issuecomment-867379735


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk closed pull request #33051: [SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields by numeric

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #33051:
URL: https://github.com/apache/spark/pull/33051


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #33051: [SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields by numeric

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33051:
URL: https://github.com/apache/spark/pull/33051#issuecomment-867542476


   Let me revert both https://github.com/apache/spark/pull/33014 and https://github.com/apache/spark/pull/33051.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org