You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/04/17 19:19:04 UTC
[kudu-CR] [Java] Clean up kudu-hive dependencies
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10089
Change subject: [Java] Clean up kudu-hive dependencies
......................................................................
[Java] Clean up kudu-hive dependencies
Cleans up the kudu-hive dependencies in the Maven
and Gradle builds. Adds a comment noting the
expectation that all dependencies come from the
hive-metastore classpath.
Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
---
M java/gradle/dependencies.gradle
M java/kudu-hive/build.gradle
M java/kudu-hive/pom.xml
3 files changed, 52 insertions(+), 49 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/10089/1
--
To view, visit http://gerrit.cloudera.org:8080/10089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
Gerrit-Change-Number: 10089
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [Java] Clean up kudu-hive dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10089 )
Change subject: [Java] Clean up kudu-hive dependencies
......................................................................
Patch Set 2:
Fixed a silly typo.
--
To view, visit http://gerrit.cloudera.org:8080/10089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
Gerrit-Change-Number: 10089
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 17 Apr 2018 19:46:21 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Clean up kudu-hive dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10089
to look at the new patch set (#2).
Change subject: [Java] Clean up kudu-hive dependencies
......................................................................
[Java] Clean up kudu-hive dependencies
Cleans up the kudu-hive dependencies in the Maven
and Gradle builds. Adds a comment noting the
expectation that all dependencies come from the
hive-metastore classpath.
Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
---
M java/gradle/dependencies.gradle
M java/kudu-hive/build.gradle
M java/kudu-hive/pom.xml
3 files changed, 52 insertions(+), 49 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/10089/2
--
To view, visit http://gerrit.cloudera.org:8080/10089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
Gerrit-Change-Number: 10089
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Clean up kudu-hive dependencies
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10089 )
Change subject: [Java] Clean up kudu-hive dependencies
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
Gerrit-Change-Number: 10089
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 17 Apr 2018 20:14:52 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Clean up kudu-hive dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [Java] Clean up kudu-hive dependencies
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
Gerrit-Change-Number: 10089
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Clean up kudu-hive dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10089 )
Change subject: [Java] Clean up kudu-hive dependencies
......................................................................
[Java] Clean up kudu-hive dependencies
Cleans up the kudu-hive dependencies in the Maven
and Gradle builds. Adds a comment noting the
expectation that all dependencies come from the
hive-metastore classpath.
Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
Reviewed-on: http://gerrit.cloudera.org:8080/10089
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/gradle/dependencies.gradle
M java/kudu-hive/build.gradle
M java/kudu-hive/pom.xml
3 files changed, 52 insertions(+), 49 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
Gerrit-Change-Number: 10089
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Clean up kudu-hive dependencies
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10089 )
Change subject: [Java] Clean up kudu-hive dependencies
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
Gerrit-Change-Number: 10089
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 17 Apr 2018 19:25:30 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Clean up kudu-hive dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10089 )
Change subject: [Java] Clean up kudu-hive dependencies
......................................................................
Patch Set 2: Verified+1
Jenkins unrelated flaky failure.
--
To view, visit http://gerrit.cloudera.org:8080/10089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e859c5cf193283343267e697c44aae4a1dd8588
Gerrit-Change-Number: 10089
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 17 Apr 2018 20:25:23 +0000
Gerrit-HasComments: No