You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/05/18 21:01:35 UTC
[GitHub] kasjer commented on issue #1101: HiFive1 add missing peripheral
driver
kasjer commented on issue #1101: HiFive1 add missing peripheral driver
URL: https://github.com/apache/mynewt-core/pull/1101#issuecomment-390331215
@mkiiskila Thanks for review, I addressed all you points. I also allowed to have rxbuf set to NULL. Before I checked STM32 code I saw that it will not work for rxbuf == NULL and I thought this is how HAL was designed. Then I noticed that @wes3 used rxbuf = NULL for led driver. So now risc-v mcu allows rxbuf = NULL as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services