You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David James <dj...@collab.net> on 2006/10/03 18:28:50 UTC
Re: svn commit: r18758 - in trunk/subversion/bindings/swig: include perl/libsvn_swig_perl perl/native perl/native/t
On 3/7/06, rooneg@tigris.org <ro...@tigris.org> wrote:
> Author: rooneg
> +/* Thunked version of svn_client_info_t callback type. */
> +svn_error_t *svn_swig_pl_info_receiver(void *baton,
> + const char *path,
> + const svn_info_t *info,
> + apr_pool_t *pool)
> +{
> + SV *result;
> + svn_error_t *ret_val;
> + swig_type_info *infoinfo = _SWIG_TYPE("svn_info_t *");
> +
> + if (!SvOK((SV *)baton))
> + return;
It isn't valid to include a bare return statement in a function that
returns svn_error_t *. Did you intend to return an error here?
Cheers,
David
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r18758 - in trunk/subversion/bindings/swig: include perl/libsvn_swig_perl perl/native perl/native/t
Posted by Daniel Rall <dl...@collab.net>.
On Tue, 03 Oct 2006, Garrett Rooney wrote:
> On 10/3/06, David James <dj...@collab.net> wrote:
> >On 3/7/06, rooneg@tigris.org <ro...@tigris.org> wrote:
> >> Author: rooneg
> >> +/* Thunked version of svn_client_info_t callback type. */
> >> +svn_error_t *svn_swig_pl_info_receiver(void *baton,
> >> + const char *path,
> >> + const svn_info_t *info,
> >> + apr_pool_t *pool)
> >> +{
> >> + SV *result;
> >> + svn_error_t *ret_val;
> >> + swig_type_info *infoinfo = _SWIG_TYPE("svn_info_t *");
> >> +
> >> + if (!SvOK((SV *)baton))
> >> + return;
> >
> >It isn't valid to include a bare return statement in a function that
> >returns svn_error_t *. Did you intend to return an error here?
>
> Oops, yeah, that does indeed look like a bug. Anyone got an idea what
> kind of error it should return?
Some sort of invalid input error...
Re: svn commit: r18758 - in trunk/subversion/bindings/swig: include perl/libsvn_swig_perl perl/native perl/native/t
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 10/3/06, David James <dj...@collab.net> wrote:
> On 3/7/06, rooneg@tigris.org <ro...@tigris.org> wrote:
> > Author: rooneg
> > +/* Thunked version of svn_client_info_t callback type. */
> > +svn_error_t *svn_swig_pl_info_receiver(void *baton,
> > + const char *path,
> > + const svn_info_t *info,
> > + apr_pool_t *pool)
> > +{
> > + SV *result;
> > + svn_error_t *ret_val;
> > + swig_type_info *infoinfo = _SWIG_TYPE("svn_info_t *");
> > +
> > + if (!SvOK((SV *)baton))
> > + return;
>
> It isn't valid to include a bare return statement in a function that
> returns svn_error_t *. Did you intend to return an error here?
Oops, yeah, that does indeed look like a bug. Anyone got an idea what
kind of error it should return?
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org