You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/05 12:44:13 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6574: [AIRFLOW-5924] Automatically unify bucket name and key in S3Hook

ashb commented on a change in pull request #6574: [AIRFLOW-5924] Automatically unify bucket name and key in S3Hook
URL: https://github.com/apache/airflow/pull/6574#discussion_r354290781
 
 

 ##########
 File path: airflow/providers/amazon/aws/hooks/s3.py
 ##########
 @@ -242,6 +267,7 @@ def list_keys(self, bucket_name=None, prefix='', delimiter='',
         return None
 
     @provide_bucket_name
+    @unify_bucket_name_and_key
 
 Review comment:
   Do we need two wrappers? Do we use one without the other?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services