You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henning Schmiedehausen (JIRA)" <ji...@apache.org> on 2007/11/13 22:24:43 UTC
[jira] Created: (COLLECTIONS-278) put() and putAll() don't update
the getKeys() map
put() and putAll() don't update the getKeys() map
-------------------------------------------------
Key: COLLECTIONS-278
URL: https://issues.apache.org/jira/browse/COLLECTIONS-278
Project: Commons Collections
Issue Type: Bug
Affects Versions: 3.2
Reporter: Henning Schmiedehausen
If you use the put() or putAll() methods of the ExtendedProperties class, it will not update the contents of the internal keysAsListed map which in turn will return a different list of keys using the getKeys() method than the keySet() method does.
The attached patchs fix this behaviour and add test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COLLECTIONS-278) put() and putAll() don't update
the getKeys() map
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell updated COLLECTIONS-278:
--------------------------------------
Attachment: COLLECTIONS-278.patch
Henning's patch had a lot of whitespace diffs, so here's a version without those changes.
> put() and putAll() don't update the getKeys() map
> -------------------------------------------------
>
> Key: COLLECTIONS-278
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-278
> Project: Commons Collections
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Henning Schmiedehausen
> Attachments: COLLECTIONS-278.patch, putall-test-patch, putall.patch
>
>
> If you use the put() or putAll() methods of the ExtendedProperties class, it will not update the contents of the internal keysAsListed map which in turn will return a different list of keys using the getKeys() method than the keySet() method does.
> The attached patchs fix this behaviour and add test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COLLECTIONS-278) put() and putAll() don't update
the getKeys() map
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen updated COLLECTIONS-278:
-----------------------------------------------
Attachment: putall-test-patch
> put() and putAll() don't update the getKeys() map
> -------------------------------------------------
>
> Key: COLLECTIONS-278
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-278
> Project: Commons Collections
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Henning Schmiedehausen
> Attachments: putall-test-patch, putall.patch
>
>
> If you use the put() or putAll() methods of the ExtendedProperties class, it will not update the contents of the internal keysAsListed map which in turn will return a different list of keys using the getKeys() method than the keySet() method does.
> The attached patchs fix this behaviour and add test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COLLECTIONS-278) put() and putAll() don't update
the getKeys() map
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen updated COLLECTIONS-278:
-----------------------------------------------
Attachment: putall.patch
> put() and putAll() don't update the getKeys() map
> -------------------------------------------------
>
> Key: COLLECTIONS-278
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-278
> Project: Commons Collections
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Henning Schmiedehausen
> Attachments: putall-test-patch, putall.patch
>
>
> If you use the put() or putAll() methods of the ExtendedProperties class, it will not update the contents of the internal keysAsListed map which in turn will return a different list of keys using the getKeys() method than the keySet() method does.
> The attached patchs fix this behaviour and add test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COLLECTIONS-278) put() and putAll() don't update
the getKeys() map
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell updated COLLECTIONS-278:
--------------------------------------
Attachment: COLLECTIONS-278.patch
Henning's patch looks good. I've added javadoc in one last patch, and I've implemented remove(Object);Object as well because it appears to me that this is another area for the same type of bug.
> put() and putAll() don't update the getKeys() map
> -------------------------------------------------
>
> Key: COLLECTIONS-278
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-278
> Project: Commons Collections
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Henning Schmiedehausen
> Fix For: 3.3
>
> Attachments: COLLECTIONS-278.patch, COLLECTIONS-278.patch, putall-test-patch, putall.patch
>
>
> If you use the put() or putAll() methods of the ExtendedProperties class, it will not update the contents of the internal keysAsListed map which in turn will return a different list of keys using the getKeys() method than the keySet() method does.
> The attached patchs fix this behaviour and add test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COLLECTIONS-278) put() and putAll() don't update
the getKeys() map
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell updated COLLECTIONS-278:
--------------------------------------
Fix Version/s: 3.3
> put() and putAll() don't update the getKeys() map
> -------------------------------------------------
>
> Key: COLLECTIONS-278
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-278
> Project: Commons Collections
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Henning Schmiedehausen
> Fix For: 3.3
>
> Attachments: COLLECTIONS-278.patch, COLLECTIONS-278.patch, putall-test-patch, putall.patch
>
>
> If you use the put() or putAll() methods of the ExtendedProperties class, it will not update the contents of the internal keysAsListed map which in turn will return a different list of keys using the getKeys() method than the keySet() method does.
> The attached patchs fix this behaviour and add test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COLLECTIONS-278) put() and putAll() don't update
the getKeys() map
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell closed COLLECTIONS-278.
-------------------------------------
Resolution: Fixed
svn ci -m "Applying the latest patch from Henning's report in COLLECTIONS-278 that put() and putAll() don't update the getKeys() map on ExtendedProperties" src
Sending src/java/org/apache/commons/collections/ExtendedProperties.java
Sending src/test/org/apache/commons/collections/TestExtendedProperties.java
Transmitting file data ..
Committed revision 637489.
> put() and putAll() don't update the getKeys() map
> -------------------------------------------------
>
> Key: COLLECTIONS-278
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-278
> Project: Commons Collections
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Henning Schmiedehausen
> Fix For: 3.3
>
> Attachments: COLLECTIONS-278.patch, COLLECTIONS-278.patch, putall-test-patch, putall.patch
>
>
> If you use the put() or putAll() methods of the ExtendedProperties class, it will not update the contents of the internal keysAsListed map which in turn will return a different list of keys using the getKeys() method than the keySet() method does.
> The attached patchs fix this behaviour and add test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.