You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by gm...@apache.org on 2007/08/24 17:01:16 UTC

svn commit: r569409 - /myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js

Author: gmuellan
Date: Fri Aug 24 08:01:16 2007
New Revision: 569409

URL: http://svn.apache.org/viewvc?rev=569409&view=rev
Log:
fix for https://issues.apache.org/jira/browse/TOMAHAWK-1096 wrong if clause was introduced due to the last commit where making jscook menu trinidad compatible

Modified:
    myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js

Modified: myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js
URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js?rev=569409&r1=569408&r2=569409&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js (original)
+++ myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js Fri Aug 24 08:01:16 2007
@@ -27,7 +27,7 @@
             // Link is a JSF action
             var dummyForm = document.forms[target];
             dummyForm.elements['jscook_action'].value = link;
-            if (submitForm === undefined) {
+            if (typeof submitForm == "undefined") {
                 //No Trinidad
                 dummyForm.submit();
             } else {



Re: svn commit: r569409 - /myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js

Posted by Matthias Wessendorf <ma...@apache.org>.
komisch....

http://developer.mozilla.org/en/docs/Core_JavaScript_1.5_Reference:Global_Properties:undefined

eigentlich funktioniert === undefined

:-)

On 8/24/07, gmuellan@apache.org <gm...@apache.org> wrote:
> Author: gmuellan
> Date: Fri Aug 24 08:01:16 2007
> New Revision: 569409
>
> URL: http://svn.apache.org/viewvc?rev=569409&view=rev
> Log:
> fix for https://issues.apache.org/jira/browse/TOMAHAWK-1096 wrong if clause was introduced due to the last commit where making jscook menu trinidad compatible
>
> Modified:
>     myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js
>
> Modified: myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js
> URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js?rev=569409&r1=569408&r2=569409&view=diff
> ==============================================================================
> --- myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js (original)
> +++ myfaces/tomahawk/trunk/core/src/main/resources/org/apache/myfaces/custom/navmenu/jscookmenu/resource/MyFacesHack.js Fri Aug 24 08:01:16 2007
> @@ -27,7 +27,7 @@
>              // Link is a JSF action
>              var dummyForm = document.forms[target];
>              dummyForm.elements['jscook_action'].value = link;
> -            if (submitForm === undefined) {
> +            if (typeof submitForm == "undefined") {
>                  //No Trinidad
>                  dummyForm.submit();
>              } else {
>
>
>


-- 
Matthias Wessendorf

further stuff:
blog: http://matthiaswessendorf.wordpress.com/
mail: matzew-at-apache-dot-org