You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Reranko05 (via GitHub)" <gi...@apache.org> on 2026/07/22 01:26:39 UTC

[PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Reranko05 opened a new pull request, #50587:
URL: https://github.com/apache/arrow/pull/50587

   ### Rationale
   
   The R build may pick up a system-installed simdjson when `simdjson_SOURCE` is not explicitly set. This causes build failures in environments where the system version is incompatible or unsuitable for the build.
   
   ### What changes are included?
   
   This change defaults `simdjson_SOURCE` to `BUNDLED` when it is not already set, ensuring the R build uses the bundled simdjson by default while still allowing users to override it explicitly.
   
   This addresses the macOS CRAN release and ubuntu-r-only-r (AUTO deps) failures reported in GH-50581.
   
   Related: #50581 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5068263840

   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5067051668

   Got it, that makes sense. I'll check `CMAKE_OSX_SYSROOT` instead of `CMAKE_CXX_COMPILER_VERSION` and see if I can restrict the workaround to the affected SDK version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5067210470

   @kou I have disabled ARROW_JSON for MacOS 11.3 SDK which is used in Crossbow `test-r-macos-as-cran` job, please re-run the Crossbow job to verify whether this resolves the issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5068653010

   @github-actions crossbow submit wheel-*-cp314-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5056887387

   test-r-depsource-system:
   
   https://github.com/ursacomputing/crossbow/actions/runs/29981142748/job/89122965384#step:6:3165
   
   ```text
   simdjson_SOURCE=BUNDLED
   ```
   
   https://github.com/ursacomputing/crossbow/actions/runs/29981142748/job/89122965384#step:7:361
   
   ```text
   CMake Error at cmake_modules/ThirdpartyToolchain.cmake:316 (message):
     Couldn't find simdjson >= 3.0.0
   ```
   
   It seems that `simdjson_SOURCE=BUNDLED` environment variable isn't used.
   
   Could you try this?
   
   ```diff
   diff --git a/r/inst/build_arrow_static.sh b/r/inst/build_arrow_static.sh
   index e7f453bb64..8c8d9d6b95 100755
   --- a/r/inst/build_arrow_static.sh
   +++ b/r/inst/build_arrow_static.sh
   @@ -107,8 +107,9 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
        -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
        -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
        -DOPENSSL_ROOT_DIR=${OPENSSL_ROOT_DIR} \
   -    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
        -Dabsl_SOURCE=${absl_SOURCE:-BUNDLED} \
   +    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
   +    -Dsimdjson_SOURCE=${simdjson_SOURCE:-} \
        -Dxsimd_SOURCE=${xsimd_SOURCE:-} \
        -Dzstd_SOURCE=${zstd_SOURCE:-} \
        ${EXTRA_CMAKE_FLAGS} \
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3637641266


##########
r/inst/build_arrow_static.sh:
##########
@@ -107,8 +107,9 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
     -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
     -DOPENSSL_ROOT_DIR=${OPENSSL_ROOT_DIR} \
-    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
     -Dabsl_SOURCE=${absl_SOURCE:-BUNDLED} \
+    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
+    -Dsimdjson_SOURCE=${simdjson_SOURCE:-} \

Review Comment:
   @kou should we accept this and remove the change in `r/tootls.nixlibs.R`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5068671647

   @github-actions crossbow submit verify-rc-*-linux-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3646671276


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,13 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 

Review Comment:
   @Reranko05 can we just add a comment here for completeness? I will merge afterwards.
   ```suggestion
   
   # The macOS 11.3 SDK has incomplete C++20 concepts support, which prevents
   # simdjson headers from compiling. Disable simdjson concepts for this SDK.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3648660200


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+# The macOS 11.3 SDK has incomplete C++20 concepts support, which prevents
+# simdjson headers from compiling. Disable simdjson concepts for this SDK.
+if(ARROW_JSON
+   AND CMAKE_OSX_SYSROOT
+   AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$")
+  message(STATUS "Disabling simdjson concepts for macOS SDK 11.3")
+  add_compile_definitions(SIMDJSON_CONCEPT_DISABLED=1)
+endif()

Review Comment:
   Sure, I will do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3643115895


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(APPLE

Review Comment:
   Right. Fixed it



##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(APPLE
+   AND CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"
+   AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "22")

Review Comment:
   Addressed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5071448096

   @rok Thanks for the review and for rerunning the Crossbow jobs :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5080711204

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 62d2dd8270a303165a5f57de97c20aa1fe09f161.
   
   There was 1 benchmark result indicating a performance regression:
   
   - Commit Run on `amd64-m5-4xlarge-linux` at [2026-07-24 18:29:49Z](https://conbench.arrow-dev.org/compare/runs/db0ff60583b141df92be45d4a1d7d8f5...6e4378242e6a49668d33ed97fdd192ea/)
     - [`dataframe-to-table` (R) with dataset=type_dict, language=R](https://conbench.arrow-dev.org/compare/benchmarks/06a638df3ca27c4f8000cee852891c88...06a63c50e8337edf800054f133ab649d)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/89725557757) has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5065980510

   @kou I tried implementing the workaround by forcibly disabling `ARROW_JSON` for AppleClang < 22 in `ThirdpartyToolchain.cmake`. Since `ARROW_WITH_SIMDJSON` is only enabled when `ARROW_JSON` is enabled, this also keeps `ARROW_WITH_SIMDJSON` disabled.
   
   I used `AppleClang < 22` instead of `<= 21` because the compiler version reported by the failing job is `21.0.0.21000101`, and `VERSION_LESS "22"` naturally covers all 21.x releases.
   
   Does this look like the right approach, or did you have something else in mind?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5056055086

   @kou I suspect the remaining Crossbow failures may be related to changes in the JsonWriter PR that haven't been merged yet (for example, it adds `simdjson_SOURCE=BUNDLED` to the R Docker test configuration, which seems relevant to the Ubuntu failure).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5068290808

   Revision: 9fe9ba191d4bcdbbf2e6d2480616ec75256e78a1
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-9d09b5d098](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9d09b5d098)
   
   |Task|Status|
   |----|------|
   |r-binary-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-r-binary-packages)](https://github.com/ursacomputing/crossbow/actions/runs/30082471716/job/89447127754)|
   |r-recheck-most|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-r-recheck-most)](https://github.com/ursacomputing/crossbow/actions/runs/30082468883/job/89446981865)|
   |test-r-alpine-linux-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-alpine-linux-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30082468353/job/89446980176)|
   |test-r-arrow-backwards-compatibility|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-arrow-backwards-compatibility)](https://github.com/ursacomputing/crossbow/actions/runs/30082471180/job/89446989341)|
   |test-r-depsource-system|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-depsource-system)](https://github.com/ursacomputing/crossbow/actions/runs/30082469616/job/89446984018)|
   |test-r-dev-duckdb|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-dev-duckdb)](https://github.com/ursacomputing/crossbow/actions/runs/30082469796/job/89446984478)|
   |test-r-devdocs|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-devdocs)](https://github.com/ursacomputing/crossbow/actions/runs/30082468995/job/89446982128)|
   |test-r-extra-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-extra-packages)](https://github.com/ursacomputing/crossbow/actions/runs/30082469401/job/89446983481)|
   |test-r-fedora-clang|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-fedora-clang)](https://github.com/ursacomputing/crossbow/actions/runs/30082468761/job/89446981590)|
   |test-r-gcc-11|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-gcc-11)](https://github.com/ursacomputing/crossbow/actions/runs/30082471126/job/89446989087)|
   |test-r-gcc-12|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-gcc-12)](https://github.com/ursacomputing/crossbow/actions/runs/30082470357/job/89446986248)|
   |test-r-install-local|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-install-local)](https://github.com/ursacomputing/crossbow/actions/runs/30082471200/job/89446989405)|
   |test-r-install-local-minsizerel|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-install-local-minsizerel)](https://github.com/ursacomputing/crossbow/actions/runs/30082468032/job/89446979283)|
   |test-r-linux-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-linux-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30082469642/job/89446984189)|
   |test-r-linux-rchk|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-linux-rchk)](https://github.com/ursacomputing/crossbow/actions/runs/30082469686/job/89446984159)|
   |test-r-linux-sanitizers|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-linux-sanitizers)](https://github.com/ursacomputing/crossbow/actions/runs/30082468550/job/89446981093)|
   |test-r-linux-valgrind|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-linux-valgrind)](https://github.com/ursacomputing/crossbow/actions/runs/30082470658/job/89446987335)|
   |test-r-m1-san|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-m1-san)](https://github.com/ursacomputing/crossbow/actions/runs/30082470218/job/89446985904)|
   |test-r-macos-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-macos-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30082468966/job/89446982169)|
   |test-r-offline-maximal|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-offline-maximal)](https://github.com/ursacomputing/crossbow/actions/runs/30082469384/job/89446983193)|
   |test-r-ubuntu-22.04|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-ubuntu-22.04)](https://github.com/ursacomputing/crossbow/actions/runs/30082469354/job/89446982982)|
   |test-r-versions|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-versions)](https://github.com/ursacomputing/crossbow/actions/runs/30082468070/job/89446979547)|
   |test-r-wasm|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9d09b5d098-github-test-r-wasm)](https://github.com/ursacomputing/crossbow/actions/runs/30082470991/job/89446988377)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3644469843


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,13 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(ARROW_JSON
+   AND CMAKE_OSX_SYSROOT
+   AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$")
+  message(STATUS "Disabling ARROW_JSON for macOS SDK 11.3")
+  set(ARROW_JSON OFF)

Review Comment:
   Thanks! The `if` condition is now being entered, the status message is printed, and the `test-r-macos-as-cran` Crossbow job passed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5054642948

   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3641224088


##########
r/inst/build_arrow_static.sh:
##########
@@ -107,8 +107,9 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
     -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
     -DOPENSSL_ROOT_DIR=${OPENSSL_ROOT_DIR} \
-    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
     -Dabsl_SOURCE=${absl_SOURCE:-BUNDLED} \
+    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
+    -Dsimdjson_SOURCE=${simdjson_SOURCE:-} \

Review Comment:
   Good point! Let's try it!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3644517389


##########
dev/tasks/r/github.macos.cran.yml:
##########
@@ -80,6 +80,7 @@ jobs:
       - name: Install (cran-release)
         if: matrix.config == 'cran-release'
         env:
+          ARROW_R_DEV: true

Review Comment:
   Right. Removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5080732700

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 62d2dd8270a303165a5f57de97c20aa1fe09f161.
   
   There was 1 benchmark result indicating a performance regression:
   
   - Commit Run on `amd64-m5-4xlarge-linux` at [2026-07-24 18:29:49Z](https://conbench.arrow-dev.org/compare/runs/db0ff60583b141df92be45d4a1d7d8f5...6e4378242e6a49668d33ed97fdd192ea/)
     - [`dataframe-to-table` (R) with dataset=type_dict, language=R](https://conbench.arrow-dev.org/compare/benchmarks/06a638df3ca27c4f8000cee852891c88...06a63c50e8337edf800054f133ab649d)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/89726128006) has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5050086764

   I don't think this is isolated to R, e.g. see [windows python nightly failure](https://github.com/ursacomputing/crossbow/actions/runs/29822857681/job/88609296806) and you can check other [nightlies](https://crossbow.arrow-dev.org/).
   I think the approach is correct though and don't worry too much about this, we have until the next release to fix it :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3649028307


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+# The macOS 11.3 SDK has incomplete C++20 concepts support, which prevents
+# simdjson headers from compiling. Disable simdjson concepts for this SDK.
+if(ARROW_JSON
+   AND CMAKE_OSX_SYSROOT
+   AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$")
+  message(STATUS "Disabling simdjson concepts for macOS SDK 11.3")
+  add_compile_definitions(SIMDJSON_CONCEPT_DISABLED=1)
+endif()

Review Comment:
   @kou I have opened a PR for this #50633 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5041318206

   Revision: 98645974f47b29559a8b0bdb0ed9cd8cbe0acf2e
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-357652d8fe](https://github.com/ursacomputing/crossbow/branches/all?query=actions-357652d8fe)
   
   |Task|Status|
   |----|------|
   |r-binary-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-r-binary-packages)](https://github.com/ursacomputing/crossbow/actions/runs/29887153182/job/88819923377)|
   |r-recheck-most|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-r-recheck-most)](https://github.com/ursacomputing/crossbow/actions/runs/29887153271/job/88819923829)|
   |test-r-alpine-linux-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-alpine-linux-cran)](https://github.com/ursacomputing/crossbow/actions/runs/29887152350/job/88819921201)|
   |test-r-arrow-backwards-compatibility|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-arrow-backwards-compatibility)](https://github.com/ursacomputing/crossbow/actions/runs/29887152057/job/88819920310)|
   |test-r-depsource-system|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-depsource-system)](https://github.com/ursacomputing/crossbow/actions/runs/29887152423/job/88819921512)|
   |test-r-dev-duckdb|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-dev-duckdb)](https://github.com/ursacomputing/crossbow/actions/runs/29887151925/job/88819919931)|
   |test-r-devdocs|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-devdocs)](https://github.com/ursacomputing/crossbow/actions/runs/29887151922/job/88819920016)|
   |test-r-extra-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-extra-packages)](https://github.com/ursacomputing/crossbow/actions/runs/29887151702/job/88819919276)|
   |test-r-fedora-clang|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-fedora-clang)](https://github.com/ursacomputing/crossbow/actions/runs/29887152679/job/88819922257)|
   |test-r-gcc-11|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-gcc-11)](https://github.com/ursacomputing/crossbow/actions/runs/29887151358/job/88819918379)|
   |test-r-gcc-12|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-gcc-12)](https://github.com/ursacomputing/crossbow/actions/runs/29887152802/job/88819922652)|
   |test-r-install-local|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-install-local)](https://github.com/ursacomputing/crossbow/actions/runs/29887152995/job/88819922935)|
   |test-r-install-local-minsizerel|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-install-local-minsizerel)](https://github.com/ursacomputing/crossbow/actions/runs/29887153027/job/88819923102)|
   |test-r-linux-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-linux-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/29887151486/job/88819918860)|
   |test-r-linux-rchk|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-linux-rchk)](https://github.com/ursacomputing/crossbow/actions/runs/29887151661/job/88819919231)|
   |test-r-linux-sanitizers|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-linux-sanitizers)](https://github.com/ursacomputing/crossbow/actions/runs/29887151960/job/88819920075)|
   |test-r-linux-valgrind|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-linux-valgrind)](https://github.com/ursacomputing/crossbow/actions/runs/29887152265/job/88819921010)|
   |test-r-m1-san|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-m1-san)](https://github.com/ursacomputing/crossbow/actions/runs/29887151336/job/88819918352)|
   |test-r-macos-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-macos-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/29887153168/job/88819923402)|
   |test-r-offline-maximal|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-offline-maximal)](https://github.com/ursacomputing/crossbow/actions/runs/29887151863/job/88819919757)|
   |test-r-ubuntu-22.04|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-ubuntu-22.04)](https://github.com/ursacomputing/crossbow/actions/runs/29887151639/job/88819919204)|
   |test-r-versions|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-versions)](https://github.com/ursacomputing/crossbow/actions/runs/29887152928/job/88819922988)|
   |test-r-wasm|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-357652d8fe-github-test-r-wasm)](https://github.com/ursacomputing/crossbow/actions/runs/29887152144/job/88819920672)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3643117446


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(APPLE
+   AND CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"
+   AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "22")
+  message(STATUS "Disabling ARROW_JSON for AppleClang < 22")
+  set(ARROW_JSON
+      OFF
+      CACHE BOOL "" FORCE)

Review Comment:
   Okay. Addressed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3643127885


##########
r/inst/build_arrow_static.sh:
##########
@@ -107,8 +107,9 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
     -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
     -DOPENSSL_ROOT_DIR=${OPENSSL_ROOT_DIR} \
-    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
     -Dabsl_SOURCE=${absl_SOURCE:-BUNDLED} \
+    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
+    -Dsimdjson_SOURCE=${simdjson_SOURCE:-} \

Review Comment:
   Added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5069236746

   @raulcd I have reverted the previous workaround and bumped the Windows wheel image revision. Could you please re-run the Crossbow jobs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5070415189

   @github-actions crossbow submit wheel-windows-cp314-cp314-amd64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5066108663

   > @github-actions crossbow submit -g r
   
   @kou can you run this again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5054323586

   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5067021519

   @kou I found the remaining issue. The minimal example was being configured as a Debug build, while the installed Arrow libraries were built in Release mode. Explicitly configuring the example with  `-DCMAKE_BUILD_TYPE=Release` fixes the build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5067347385

   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5068992298

   The Windows wheels jobs are already failing on the nightlies related to simdjson, wasn't this expected to fix those?
   As per the verification jobs, those failures are also happening on the nightlies but those don't seem related to simdjson.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5069162028

   Thanks @Reranko05 @rok I think that if we update the image revision for the Windows wheels, using `-Dsimdjson_SOURCE=BUNDLED` is unnecessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5069474882

   Revision: e470cf0ced3c16cdd77f9cd9dd15e010e1e20a9f
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-ebacba2792](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ebacba2792)
   
   |Task|Status|
   |----|------|
   |wheel-windows-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ebacba2792-github-wheel-windows-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30090513714/job/89472520385)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5054669283

   Revision: 09faaf95f148694173136cc85184d4da6fda3770
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-95f15c568e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-95f15c568e)
   
   |Task|Status|
   |----|------|
   |r-binary-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-r-binary-packages)](https://github.com/ursacomputing/crossbow/actions/runs/29981142712/job/89122965413)|
   |r-recheck-most|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-r-recheck-most)](https://github.com/ursacomputing/crossbow/actions/runs/29981143626/job/89122968648)|
   |test-r-alpine-linux-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-alpine-linux-cran)](https://github.com/ursacomputing/crossbow/actions/runs/29981143466/job/89122967822)|
   |test-r-arrow-backwards-compatibility|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-arrow-backwards-compatibility)](https://github.com/ursacomputing/crossbow/actions/runs/29981141491/job/89122961814)|
   |test-r-depsource-system|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-depsource-system)](https://github.com/ursacomputing/crossbow/actions/runs/29981142748/job/89122965384)|
   |test-r-dev-duckdb|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-dev-duckdb)](https://github.com/ursacomputing/crossbow/actions/runs/29981142823/job/89122965745)|
   |test-r-devdocs|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-devdocs)](https://github.com/ursacomputing/crossbow/actions/runs/29981141782/job/89122962871)|
   |test-r-extra-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-extra-packages)](https://github.com/ursacomputing/crossbow/actions/runs/29981143004/job/89122966237)|
   |test-r-fedora-clang|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-fedora-clang)](https://github.com/ursacomputing/crossbow/actions/runs/29981143276/job/89122967165)|
   |test-r-gcc-11|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-gcc-11)](https://github.com/ursacomputing/crossbow/actions/runs/29981142176/job/89122963940)|
   |test-r-gcc-12|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-gcc-12)](https://github.com/ursacomputing/crossbow/actions/runs/29981141637/job/89122962354)|
   |test-r-install-local|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-install-local)](https://github.com/ursacomputing/crossbow/actions/runs/29981142623/job/89122965043)|
   |test-r-install-local-minsizerel|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-install-local-minsizerel)](https://github.com/ursacomputing/crossbow/actions/runs/29981143020/job/89122966238)|
   |test-r-linux-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-linux-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/29981142442/job/89122964604)|
   |test-r-linux-rchk|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-linux-rchk)](https://github.com/ursacomputing/crossbow/actions/runs/29981142878/job/89122965900)|
   |test-r-linux-sanitizers|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-linux-sanitizers)](https://github.com/ursacomputing/crossbow/actions/runs/29981142318/job/89122964532)|
   |test-r-linux-valgrind|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-linux-valgrind)](https://github.com/ursacomputing/crossbow/actions/runs/29981142635/job/89122965149)|
   |test-r-m1-san|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-m1-san)](https://github.com/ursacomputing/crossbow/actions/runs/29981142072/job/89122963747)|
   |test-r-macos-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-macos-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/29981142927/job/89122966063)|
   |test-r-offline-maximal|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-offline-maximal)](https://github.com/ursacomputing/crossbow/actions/runs/29981142000/job/89122963433)|
   |test-r-ubuntu-22.04|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-ubuntu-22.04)](https://github.com/ursacomputing/crossbow/actions/runs/29981141788/job/89122962892)|
   |test-r-versions|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-versions)](https://github.com/ursacomputing/crossbow/actions/runs/29981142074/job/89122963615)|
   |test-r-wasm|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-95f15c568e-github-test-r-wasm)](https://github.com/ursacomputing/crossbow/actions/runs/29981143127/job/89122966665)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5041296701

   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5054328521

   ```
   Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
   The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/29979508366
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5057812026

   @rok Updated PR title and description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5066376437

   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3637641266


##########
r/inst/build_arrow_static.sh:
##########
@@ -107,8 +107,9 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
     -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
     -DOPENSSL_ROOT_DIR=${OPENSSL_ROOT_DIR} \
-    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
     -Dabsl_SOURCE=${absl_SOURCE:-BUNDLED} \
+    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
+    -Dsimdjson_SOURCE=${simdjson_SOURCE:-} \

Review Comment:
   @kou should we accept this and remove the change in `r/tootls/nixlibs.R`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5066669704

   > Can we disable ARROW_JSON and ARROW_WITH_SIMDJSON forcibly with AppleClang 21 or older?
   
   @kou I noticed that the regular macOS CI jobs use older AppleClang versions:
   
   - AMD64 macOS 15: AppleClang 17.0.0.17000013
   - ARM64 macOS 14: AppleClang 15.0.0.15000309
   
   whereas the Crossbow failure was on AppleClang 21.0.0.21000101.
   
   My current condition (`AppleClang < 22`) also disables `ARROW_JSON` for AppleClang 15 and 17, which causes the regular macOS C++ CI to fail because the JSON library is no longer built.
   
   Would it make more sense to limit this workaround to AppleClang 21.x instead?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5066932386

   Ah, we need to check macOS SDK version not AppleClang version...
   We may be able to `CMAKE_OSX_SYSROOT` https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_SYSROOT.html for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5067369377

   Revision: 3432892d0e630a50d3d564ab834775ef2ea0aa60
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-74545806bc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-74545806bc)
   
   |Task|Status|
   |----|------|
   |r-binary-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-r-binary-packages)](https://github.com/ursacomputing/crossbow/actions/runs/30075958538/job/89426742404)|
   |r-recheck-most|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-r-recheck-most)](https://github.com/ursacomputing/crossbow/actions/runs/30075958562/job/89426613908)|
   |test-r-alpine-linux-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-alpine-linux-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30075958554/job/89426613730)|
   |test-r-arrow-backwards-compatibility|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-arrow-backwards-compatibility)](https://github.com/ursacomputing/crossbow/actions/runs/30075957993/job/89426612665)|
   |test-r-depsource-system|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-depsource-system)](https://github.com/ursacomputing/crossbow/actions/runs/30075956653/job/89426608389)|
   |test-r-dev-duckdb|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-dev-duckdb)](https://github.com/ursacomputing/crossbow/actions/runs/30075959056/job/89426615561)|
   |test-r-devdocs|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-devdocs)](https://github.com/ursacomputing/crossbow/actions/runs/30075958237/job/89426612902)|
   |test-r-extra-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-extra-packages)](https://github.com/ursacomputing/crossbow/actions/runs/30075956880/job/89426609145)|
   |test-r-fedora-clang|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-fedora-clang)](https://github.com/ursacomputing/crossbow/actions/runs/30075957295/job/89426610373)|
   |test-r-gcc-11|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-gcc-11)](https://github.com/ursacomputing/crossbow/actions/runs/30075957172/job/89426609949)|
   |test-r-gcc-12|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-gcc-12)](https://github.com/ursacomputing/crossbow/actions/runs/30075957297/job/89426610236)|
   |test-r-install-local|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-install-local)](https://github.com/ursacomputing/crossbow/actions/runs/30075959082/job/89426615692)|
   |test-r-install-local-minsizerel|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-install-local-minsizerel)](https://github.com/ursacomputing/crossbow/actions/runs/30075957533/job/89426611066)|
   |test-r-linux-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-linux-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30075958569/job/89426614164)|
   |test-r-linux-rchk|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-linux-rchk)](https://github.com/ursacomputing/crossbow/actions/runs/30075958961/job/89426615244)|
   |test-r-linux-sanitizers|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-linux-sanitizers)](https://github.com/ursacomputing/crossbow/actions/runs/30075959233/job/89426616088)|
   |test-r-linux-valgrind|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-linux-valgrind)](https://github.com/ursacomputing/crossbow/actions/runs/30075956216/job/89426608174)|
   |test-r-m1-san|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-m1-san)](https://github.com/ursacomputing/crossbow/actions/runs/30075957226/job/89426610029)|
   |test-r-macos-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-macos-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30075958442/job/89426613574)|
   |test-r-offline-maximal|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-offline-maximal)](https://github.com/ursacomputing/crossbow/actions/runs/30075956536/job/89426608329)|
   |test-r-ubuntu-22.04|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-ubuntu-22.04)](https://github.com/ursacomputing/crossbow/actions/runs/30075957389/job/89426610438)|
   |test-r-versions|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-versions)](https://github.com/ursacomputing/crossbow/actions/runs/30075958640/job/89426614171)|
   |test-r-wasm|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74545806bc-github-test-r-wasm)](https://github.com/ursacomputing/crossbow/actions/runs/30075958585/job/89426613740)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3644086799


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,13 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(ARROW_JSON
+   AND CMAKE_OSX_SYSROOT
+   AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$")
+  message(STATUS "Disabling ARROW_JSON for macOS SDK 11.3")
+  set(ARROW_JSON OFF)

Review Comment:
   I agree this approach is more appropriate if it works. However, I checked the latest Crossbow job and the `Disabling ARROW_JSON for macOS SDK 11.3` status message never appears, which suggests the if condition isn't being entered at all. So firstly we need to understand why that condition isn't matching.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5070436640

   Revision: e470cf0ced3c16cdd77f9cd9dd15e010e1e20a9f
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-03d0412c61](https://github.com/ursacomputing/crossbow/branches/all?query=actions-03d0412c61)
   
   |Task|Status|
   |----|------|
   |wheel-windows-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-03d0412c61-github-wheel-windows-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30097342806/job/89494532123)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5040799021

   :warning: GitHub issue #50581 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5053624683

   Could you try this?
   
   ```diff
   diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
   index 1677b188b9..dc8629669f 100644
   --- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
   +++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
   @@ -2828,7 +2828,7 @@ function(build_simdjson)
          TRUE
          PARENT_SCOPE)
    
   -  list(APPEND ARROW_BUNDLED_STATIC_LIBS simdjson::simdjson)
   +  list(APPEND ARROW_BUNDLED_STATIC_LIBS simdjson)
      set(ARROW_BUNDLED_STATIC_LIBS
          "${ARROW_BUNDLED_STATIC_LIBS}"
          PARENT_SCOPE)
   @@ -2845,6 +2845,11 @@ if(ARROW_WITH_SIMDJSON)
                         ${ARROW_SIMDJSON_REQUIRED_VERSION}
                         IS_RUNTIME_DEPENDENCY
                         FALSE)
   +  if(SIMDJSON_VENDORED)
   +    add_library(arrow::simdjson ALIAS simdjson)
   +  else()
   +    add_library(arrow::simdjson ALIAS simdjson::simdjson)
   +  endif()
    endif()
    
    function(build_rapidjson)
   diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
   index e792574a18..0b21fec605 100644
   --- a/cpp/src/arrow/CMakeLists.txt
   +++ b/cpp/src/arrow/CMakeLists.txt
   @@ -1044,7 +1044,7 @@ if(ARROW_JSON)
                               json/parser.cc
                               json/reader.cc)
      foreach(ARROW_JSON_TARGET ${ARROW_JSON_TARGETS})
   -    target_link_libraries(${ARROW_JSON_TARGET} PRIVATE RapidJSON simdjson::simdjson)
   +    target_link_libraries(${ARROW_JSON_TARGET} PRIVATE RapidJSON arrow::simdjson)
      endforeach()
    else()
      set(ARROW_JSON_TARGET_SHARED)
   ```
   
   This will fix the following case:
   
   https://github.com/ursacomputing/crossbow/actions/runs/29887151358/job/88819918379#step:6:8835
   
   ```text
   /usr/bin/ar: /usr/lib/x86_64-linux-gnu/libsimdjson.so.9.0.0: file format not recognized
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5056780520

   test-r-macos-as-cran:
   
   https://github.com/ursacomputing/crossbow/actions/runs/29981142927/job/89122965972#step:9:1373
   
   ```text
   In file included from /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/json/object_parser.cc:20:
   /opt/homebrew/include/simdjson.h:3106:10: error: expected concept name with optional arguments
    3106 |     } -> std::convertible_to<typename std::remove_cvref_t<T>::value_type>;
         |          ^
   /opt/homebrew/include/simdjson.h:3127:8: error: no member named 'ranges' in namespace 'std'
    3127 |   std::ranges::input_range<T> && !string_like<T> && !concepts::string_view_keyed_map<T>;
         |   ~~~~~^
   /opt/homebrew/include/simdjson.h:3127:28: error: 'T' does not refer to a value
    3127 |   std::ranges::input_range<T> && !string_like<T> && !concepts::string_view_keyed_map<T>;
         |                            ^
   /opt/homebrew/include/simdjson.h:3125:20: note: declared here
    3125 | template <typename T>
         |                    ^
   /opt/homebrew/include/simdjson.h:3127:34: error: expected identifier
    3127 |   std::ranges::input_range<T> && !string_like<T> && !concepts::string_view_keyed_map<T>;
         |                                  ^
   /opt/homebrew/include/simdjson.h:3140:17: error: expected concept name with optional arguments
    3140 |     { c[i] } -> std::convertible_to<typename Container::value_type>;
         |                 ^
   In file included from /var/folders/8j/sfr9qqcj73j4p6nhwcfpr0th0000gn/T/RtmpjwvCVB/file223d386e52a2/_deps/azure_sdk-src/sdk/core/azure-core/src/http/request_activity_policy.cpp:4:
   /var/folders/8j/sfr9qqcj73j4p6nhwcfpr0th0000gn/T/RtmpjwvCVB/file223d386e52a2/_deps/azure_sdk-src/sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp:429:20: warning: virtual method 'ShouldRetryOnTransportFailure' is inside a 'final' class and can never be overridden [-Wunnecessary-virtual-specifier]
     429 |       virtual bool ShouldRetryOnTransportFailure(
         |                    ^
   /var/folders/8j/sfr9qqcj73j4p6nhwcfpr0th0000gn/T/RtmpjwvCVB/file223d386e52a2/_deps/azure_sdk-src/sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp:435:20: warning: virtual method 'ShouldRetryOnResponse' is inside a 'final' class and can never be overridden [-Wunnecessary-virtual-specifier]
     435 |       virtual bool ShouldRetryOnResponse(
         |                    ^
   /opt/homebrew/include/simdjson.h:63624:19: error: no member named 'invocable' in namespace 'std'
    63624 |     requires std::invocable<Func, value>
          |                   ^~~~~~~~~
   /opt/homebrew/include/simdjson.h:63823:19: error: no member named 'invocable' in namespace 'std'
    63823 |     requires std::invocable<Func, arm64::ondemand::value>
          |                   ^~~~~~~~~
   /opt/homebrew/include/simdjson.h:65348:19: error: no member named 'invocable' in namespace 'std'
    65348 |     requires std::invocable<Func, value>
          |                   ^~~~~~~~~
   /opt/homebrew/include/simdjson.h:65478:19: error: no member named 'invocable' in namespace 'std'
    65478 |     requires std::invocable<Func, arm64::ondemand::value>
          |                   ^~~~~~~~~
   /opt/homebrew/include/simdjson.h:66395:19: error: no member named 'invocable' in namespace 'std'
    66395 |     requires std::invocable<Func, value>
          |                   ^~~~~~~~~
   /opt/homebrew/include/simdjson.h:66622:19: error: no member named 'invocable' in namespace 'std'
    66622 |     requires std::invocable<Func, value>
          |                   ^~~~~~~~~
   /opt/homebrew/include/simdjson.h:66714:19: error: no member named 'invocable' in namespace 'std'
    66714 |     requires std::invocable<Func, arm64::ondemand::value>
          |                   ^~~~~~~~~
   /opt/homebrew/include/simdjson.h:66805:19: error: no member named 'invocable' in namespace 'std'
    66805 |     requires std::invocable<Func, arm64::ondemand::value>
          |                   ^~~~~~~~~
   /opt/homebrew/include/simdjson.h:67472:19: error: no member named 'invocable' in namespace 'std'
    67472 |     requires std::invocable<Func, value>
          |                   ^~~~~~~~~
   /opt/homebrew/include/simdjson.h:67628:19: error: no member named 'invocable' in namespace 'std'
    67628 |     requires std::invocable<Func, arm64::ondemand::value>
          |                   ^~~~~~~~~
   /opt/homebrew/include/simdjson.h:67910:16: error: no type named 'unsigned_integral' in namespace 'std'
    67910 | template <std::unsigned_integral T>
          |           ~~~~~^
   /opt/homebrew/include/simdjson.h:67911:51: error: unknown type name 'T'
    67911 | error_code tag_invoke(deserialize_tag, auto &val, T &out) noexcept {
          |                                                   ^
   /opt/homebrew/include/simdjson.h:67912:38: error: template argument for template type parameter must be a type
    67912 |   using limits = std::numeric_limits<T>;
          |                                      ^
   /Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/limits:442:17: note: template parameter is declared here
     442 | template <class _Tp>
         |                 ^
   In file included from /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/json/object_parser.cc:20:
   /opt/homebrew/include/simdjson.h:67916:12: error: use of undeclared identifier 'limits'
    67916 |   if (x > (limits::max)()) {
          |            ^
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   20 errors generated.
   ```
   
   It seems that we can't build simdjson with AppleClang 21:
   
   https://github.com/ursacomputing/crossbow/actions/runs/29981142927/job/89122965972#step:9:56
   
   ```text
   -- The C compiler identification is AppleClang 21.0.0.21000101
   -- The CXX compiler identification is AppleClang 21.0.0.21000101
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5056985708

   It seems that r-recheck-most failures are unrelated.
   I've re-run it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5063205112

   Revision: b265939cf297db548e5b7dfbaf49d43b04e7e353
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-aa46ed246c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-aa46ed246c)
   
   |Task|Status|
   |----|------|
   |r-binary-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-r-binary-packages)](https://github.com/ursacomputing/crossbow/actions/runs/30042948807/job/89327280335)|
   |r-recheck-most|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-r-recheck-most)](https://github.com/ursacomputing/crossbow/actions/runs/30042949536/job/89327091390)|
   |test-r-alpine-linux-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-alpine-linux-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30042946214/job/89327080579)|
   |test-r-arrow-backwards-compatibility|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-arrow-backwards-compatibility)](https://github.com/ursacomputing/crossbow/actions/runs/30042947081/job/89327083286)|
   |test-r-depsource-system|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-depsource-system)](https://github.com/ursacomputing/crossbow/actions/runs/30042947650/job/89327085851)|
   |test-r-dev-duckdb|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-dev-duckdb)](https://github.com/ursacomputing/crossbow/actions/runs/30042946879/job/89327082515)|
   |test-r-devdocs|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-devdocs)](https://github.com/ursacomputing/crossbow/actions/runs/30042947712/job/89327085791)|
   |test-r-extra-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-extra-packages)](https://github.com/ursacomputing/crossbow/actions/runs/30042946535/job/89327081605)|
   |test-r-fedora-clang|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-fedora-clang)](https://github.com/ursacomputing/crossbow/actions/runs/30042945511/job/89327077930)|
   |test-r-gcc-11|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-gcc-11)](https://github.com/ursacomputing/crossbow/actions/runs/30042946249/job/89327080572)|
   |test-r-gcc-12|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-gcc-12)](https://github.com/ursacomputing/crossbow/actions/runs/30042946630/job/89327081885)|
   |test-r-install-local|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-install-local)](https://github.com/ursacomputing/crossbow/actions/runs/30042945294/job/89327077311)|
   |test-r-install-local-minsizerel|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-install-local-minsizerel)](https://github.com/ursacomputing/crossbow/actions/runs/30042946858/job/89327082723)|
   |test-r-linux-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-linux-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30042946326/job/89327080850)|
   |test-r-linux-rchk|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-linux-rchk)](https://github.com/ursacomputing/crossbow/actions/runs/30042944741/job/89327075537)|
   |test-r-linux-sanitizers|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-linux-sanitizers)](https://github.com/ursacomputing/crossbow/actions/runs/30042947854/job/89327086030)|
   |test-r-linux-valgrind|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-linux-valgrind)](https://github.com/ursacomputing/crossbow/actions/runs/30042947256/job/89327084002)|
   |test-r-m1-san|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-m1-san)](https://github.com/ursacomputing/crossbow/actions/runs/30042943991/job/89327073499)|
   |test-r-macos-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-macos-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30042946310/job/89327080604)|
   |test-r-offline-maximal|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-offline-maximal)](https://github.com/ursacomputing/crossbow/actions/runs/30042946085/job/89327079917)|
   |test-r-ubuntu-22.04|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-ubuntu-22.04)](https://github.com/ursacomputing/crossbow/actions/runs/30042945415/job/89327077575)|
   |test-r-versions|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-versions)](https://github.com/ursacomputing/crossbow/actions/runs/30042948032/job/89327087076)|
   |test-r-wasm|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-aa46ed246c-github-test-r-wasm)](https://github.com/ursacomputing/crossbow/actions/runs/30042944680/job/89327075572)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3642987017


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(APPLE

Review Comment:
   `APPLE` is redundant. `AppleClang` is available only on Apple.
   



##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(APPLE
+   AND CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"
+   AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "22")

Review Comment:
   Could you check this only when `ARROW_JSON=ON`?
   
   ```suggestion
   if(ARROW_JSON
      AND CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"
      AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "22")
   ```



##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(APPLE
+   AND CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"
+   AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "22")
+  message(STATUS "Disabling ARROW_JSON for AppleClang < 22")
+  set(ARROW_JSON
+      OFF
+      CACHE BOOL "" FORCE)

Review Comment:
   We can treat `ARROW_JSON` as a normal variable.
   
   ```suggestion
     set(ARROW_JSON OFF)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5068696482

   Revision: 179a1a27bd7c2c5283071feed29df499c560f926
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-8302c4cc79](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8302c4cc79)
   
   |Task|Status|
   |----|------|
   |verify-rc-source-cpp-linux-almalinux-10-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-cpp-linux-almalinux-10-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085545310/job/89456769220)|
   |verify-rc-source-cpp-linux-conda-latest-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-cpp-linux-conda-latest-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085545097/job/89456771208)|
   |verify-rc-source-cpp-linux-ubuntu-22.04-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-cpp-linux-ubuntu-22.04-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085543617/job/89456764233)|
   |verify-rc-source-cpp-linux-ubuntu-24.04-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-cpp-linux-ubuntu-24.04-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085545388/job/89456769525)|
   |verify-rc-source-integration-linux-almalinux-10-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-integration-linux-almalinux-10-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085544659/job/89456767656)|
   |verify-rc-source-integration-linux-conda-latest-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-integration-linux-conda-latest-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085543666/job/89456764304)|
   |verify-rc-source-integration-linux-ubuntu-22.04-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-integration-linux-ubuntu-22.04-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085544435/job/89456766830)|
   |verify-rc-source-integration-linux-ubuntu-24.04-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-integration-linux-ubuntu-24.04-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085544437/job/89456766933)|
   |verify-rc-source-python-linux-almalinux-10-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-python-linux-almalinux-10-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085543770/job/89456764619)|
   |verify-rc-source-python-linux-conda-latest-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-python-linux-conda-latest-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085545147/job/89456768962)|
   |verify-rc-source-python-linux-ubuntu-22.04-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-python-linux-ubuntu-22.04-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085545101/job/89456768835)|
   |verify-rc-source-python-linux-ubuntu-24.04-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-python-linux-ubuntu-24.04-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085543911/job/89456765067)|
   |verify-rc-source-ruby-linux-almalinux-10-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-ruby-linux-almalinux-10-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085544565/job/89456767204)|
   |verify-rc-source-ruby-linux-conda-latest-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-ruby-linux-conda-latest-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085544633/job/89456767568)|
   |verify-rc-source-ruby-linux-ubuntu-22.04-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-ruby-linux-ubuntu-22.04-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085544302/job/89456766346)|
   |verify-rc-source-ruby-linux-ubuntu-24.04-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-8302c4cc79-github-verify-rc-source-ruby-linux-ubuntu-24.04-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085544370/job/89456766583)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5069138015

   simdjson should be installed as per:
   https://github.com/apache/arrow/blob/24823829e0e0378a08cbb1a3292573c97e56fda3/ci/vcpkg/vcpkg.json#L57-L63
   
   Can you bump the windows docker images tag so they are rebuilt and the dependency is installed:
   https://github.com/apache/arrow/blob/24823829e0e0378a08cbb1a3292573c97e56fda3/.env#L97-L102
   
   This could be fixed on this PR as the previous simdjson one broke it :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3646767601


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,13 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5048853540

   @kou It looks like the remaining failures are related to the ongoing simdjson version discussion. If we go with requiring simdjson 4.0+ and falling back to the bundled version when the system package is too old, I think that should address this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3644054071


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,13 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(ARROW_JSON
+   AND CMAKE_OSX_SYSROOT
+   AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$")
+  message(STATUS "Disabling ARROW_JSON for macOS SDK 11.3")
+  set(ARROW_JSON OFF)

Review Comment:
   This is to solve the [latest crossbow CRAN job error](https://github.com/ursacomputing/crossbow/actions/runs/30075958442/job/89426613521#step:9:45):
   
   
   ```bash
   arrowExports.cpp:1975:97: error: no member named 'json' in namespace 'arrow'
    1975 | std::shared_ptr<ds::JsonFileFormat> dataset___JsonFileFormat__Make(const std::shared_ptr<arrow::json::ParseOptions>& parse_options, const std::shared_ptr<arrow::json::ReadOptions>& read_options);
         |                                                                                          ~~~~~~~^
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3644186166


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,13 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(ARROW_JSON
+   AND CMAKE_OSX_SYSROOT
+   AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$")
+  message(STATUS "Disabling ARROW_JSON for macOS SDK 11.3")
+  set(ARROW_JSON OFF)

Review Comment:
   I don't think CMAKE output will be printed as is. Perhaps enable ARROW_R_DEV flag to make sure your ("Disabling ARROW_JSON for macOS SDK 11.3") message is printed:
   
   ```diff
   diff --git a/dev/tasks/r/github.macos.cran.yml b/dev/tasks/r/github.macos.cran.yml
   --- a/dev/tasks/r/github.macos.cran.yml
   +++ b/dev/tasks/r/github.macos.cran.yml
   @@ -80,6 +80,7 @@ jobs:
         - name: Install (cran-release)
           if: matrix.config == 'cran-release'
           env:
   +          ARROW_R_DEV: true
             _R_CHECK_CRAN_INCOMING_: false
             SDKROOT: '/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk'
             NOT_CRAN: false
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3644230426


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,13 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(ARROW_JSON
+   AND CMAKE_OSX_SYSROOT
+   AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$")
+  message(STATUS "Disabling ARROW_JSON for macOS SDK 11.3")
+  set(ARROW_JSON OFF)

Review Comment:
   Thanks! I've applied your suggestion by switching to `SIMDJSON_CONCEPT_DISABLED=1` and enabling `ARROW_R_DEV`. Could you please re-run the Crossbow job so we can verify whether the condition is being hit and whether this resolves the build failure?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3644486855


##########
dev/tasks/r/github.macos.cran.yml:
##########
@@ -80,6 +80,7 @@ jobs:
       - name: Install (cran-release)
         if: matrix.config == 'cran-release'
         env:
+          ARROW_R_DEV: true

Review Comment:
   Reminder to remove this before we merge.
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5069179023

   Thanks @raulcd, I will revert the workaround and update the image revision instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3642984394


##########
r/inst/build_arrow_static.sh:
##########
@@ -107,8 +107,9 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
     -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
     -DOPENSSL_ROOT_DIR=${OPENSSL_ROOT_DIR} \
-    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
     -Dabsl_SOURCE=${absl_SOURCE:-BUNDLED} \
+    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
+    -Dsimdjson_SOURCE=${simdjson_SOURCE:-} \

Review Comment:
   @Reranko05 Could you try this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5066393493

   Revision: 06732bd06fe4ab39ab18b914816906592dbc44c1
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-34336c535c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-34336c535c)
   
   |Task|Status|
   |----|------|
   |r-binary-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-r-binary-packages)](https://github.com/ursacomputing/crossbow/actions/runs/30068832376/job/89405190149)|
   |r-recheck-most|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-r-recheck-most)](https://github.com/ursacomputing/crossbow/actions/runs/30068833042/job/89405095340)|
   |test-r-alpine-linux-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-alpine-linux-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30068831966/job/89405091616)|
   |test-r-arrow-backwards-compatibility|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-arrow-backwards-compatibility)](https://github.com/ursacomputing/crossbow/actions/runs/30068832561/job/89405093710)|
   |test-r-depsource-system|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-depsource-system)](https://github.com/ursacomputing/crossbow/actions/runs/30068833034/job/89405095218)|
   |test-r-dev-duckdb|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-dev-duckdb)](https://github.com/ursacomputing/crossbow/actions/runs/30068833376/job/89405096219)|
   |test-r-devdocs|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-devdocs)](https://github.com/ursacomputing/crossbow/actions/runs/30068832402/job/89405093177)|
   |test-r-extra-packages|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-extra-packages)](https://github.com/ursacomputing/crossbow/actions/runs/30068832782/job/89405094434)|
   |test-r-fedora-clang|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-fedora-clang)](https://github.com/ursacomputing/crossbow/actions/runs/30068832448/job/89405093272)|
   |test-r-gcc-11|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-gcc-11)](https://github.com/ursacomputing/crossbow/actions/runs/30068833517/job/89405096796)|
   |test-r-gcc-12|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-gcc-12)](https://github.com/ursacomputing/crossbow/actions/runs/30068832605/job/89405093749)|
   |test-r-install-local|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-install-local)](https://github.com/ursacomputing/crossbow/actions/runs/30068832248/job/89405092576)|
   |test-r-install-local-minsizerel|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-install-local-minsizerel)](https://github.com/ursacomputing/crossbow/actions/runs/30068833866/job/89405097658)|
   |test-r-linux-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-linux-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30068832766/job/89405094654)|
   |test-r-linux-rchk|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-linux-rchk)](https://github.com/ursacomputing/crossbow/actions/runs/30068833592/job/89405096945)|
   |test-r-linux-sanitizers|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-linux-sanitizers)](https://github.com/ursacomputing/crossbow/actions/runs/30068833185/job/89405095732)|
   |test-r-linux-valgrind|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-linux-valgrind)](https://github.com/ursacomputing/crossbow/actions/runs/30068833205/job/89405095702)|
   |test-r-m1-san|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-m1-san)](https://github.com/ursacomputing/crossbow/actions/runs/30068833004/job/89405095350)|
   |test-r-macos-as-cran|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-macos-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/30068832711/job/89405094243)|
   |test-r-offline-maximal|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-offline-maximal)](https://github.com/ursacomputing/crossbow/actions/runs/30068833692/job/89405097323)|
   |test-r-ubuntu-22.04|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-ubuntu-22.04)](https://github.com/ursacomputing/crossbow/actions/runs/30068832479/job/89405093368)|
   |test-r-versions|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-versions)](https://github.com/ursacomputing/crossbow/actions/runs/30068833279/job/89405096208)|
   |test-r-wasm|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-34336c535c-github-test-r-wasm)](https://github.com/ursacomputing/crossbow/actions/runs/30068832158/job/89405092072)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3648281579


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,15 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+# The macOS 11.3 SDK has incomplete C++20 concepts support, which prevents
+# simdjson headers from compiling. Disable simdjson concepts for this SDK.
+if(ARROW_JSON
+   AND CMAKE_OSX_SYSROOT
+   AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$")
+  message(STATUS "Disabling simdjson concepts for macOS SDK 11.3")
+  add_compile_definitions(SIMDJSON_CONCEPT_DISABLED=1)
+endif()

Review Comment:
   @Reranko05 Could you move this to `build_simdjson()` and use `target_compile_options()` instead of `add_compile_definitions()` as a follow-up task?
   
   Could you report this to upstream? Upstream also checks clang version but we need to SDK version not clang version.
   https://github.com/simdjson/simdjson/blob/8e6bac94877f2d3d026000d36ce81e0aaf38d26f/include/simdjson/compiler_check.h#L83-L87



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [R] Use bundled simdjson by default [arrow]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3637371027


##########
r/inst/build_arrow_static.sh:
##########
@@ -107,8 +107,9 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
     -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
     -DOPENSSL_ROOT_DIR=${OPENSSL_ROOT_DIR} \
-    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
     -Dabsl_SOURCE=${absl_SOURCE:-BUNDLED} \
+    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
+    -Dsimdjson_SOURCE=${simdjson_SOURCE:-} \

Review Comment:
   `build_arrow_static.sh` now always passes `-Dsimdjson_SOURCE=${simdjson_SOURCE:-}`. When `simdjson_SOURCE` is unset and `ARROW_DEPENDENCY_SOURCE` defaults to `AUTO` in this script, CMake will fall back to `simdjson_SOURCE=AUTO` and can still pick up an incompatible system simdjson (the failure this PR is trying to avoid) when the script is invoked directly. Defaulting this to `BUNDLED` here makes the behavior consistent and reduces reliance on callers to set `simdjson_SOURCE`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3644037783


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -410,6 +410,13 @@ if(ARROW_AZURE)
   set(ARROW_WITH_AZURE_SDK ON)
 endif()
 
+if(ARROW_JSON
+   AND CMAKE_OSX_SYSROOT
+   AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$")
+  message(STATUS "Disabling ARROW_JSON for macOS SDK 11.3")
+  set(ARROW_JSON OFF)

Review Comment:
   My 🤖 says: "SIMDJSON_CONCEPT_DISABLED is supported by simdjson and avoids using the incomplete C++20 concepts implementation in the macOS 11.3 SDK."
   
   ```suggestion
     message(STATUS "Disabling simdjson concepts for macOS SDK 11.3")
     add_compile_definitions(SIMDJSON_CONCEPT_DISABLED=1)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5068678521

   Revision: 179a1a27bd7c2c5283071feed29df499c560f926
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-3dbf55330d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3dbf55330d)
   
   |Task|Status|
   |----|------|
   |wheel-macos-monterey-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-macos-monterey-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085426357/job/89456384643)|
   |wheel-macos-monterey-cp314-cp314-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-macos-monterey-cp314-cp314-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/30085425379/job/89456382053)|
   |wheel-macos-monterey-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-macos-monterey-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085425887/job/89456383051)|
   |wheel-macos-monterey-cp314-cp314t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-macos-monterey-cp314-cp314t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/30085426550/job/89456385616)|
   |wheel-manylinux-2-28-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-manylinux-2-28-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085425380/job/89456381861)|
   |wheel-manylinux-2-28-cp314-cp314-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-manylinux-2-28-cp314-cp314-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/30085425190/job/89456381093)|
   |wheel-manylinux-2-28-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-manylinux-2-28-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085425304/job/89456381275)|
   |wheel-manylinux-2-28-cp314-cp314t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-manylinux-2-28-cp314-cp314t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/30085425242/job/89456381005)|
   |wheel-musllinux-1-2-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-musllinux-1-2-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085425350/job/89456381434)|
   |wheel-musllinux-1-2-cp314-cp314-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-musllinux-1-2-cp314-cp314-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/30085426519/job/89456385159)|
   |wheel-musllinux-1-2-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-musllinux-1-2-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085425520/job/89456382005)|
   |wheel-musllinux-1-2-cp314-cp314t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-musllinux-1-2-cp314-cp314t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/30085424779/job/89456379750)|
   |wheel-windows-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-windows-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085426270/job/89456384346)|
   |wheel-windows-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3dbf55330d-github-wheel-windows-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/30085425714/job/89456382502)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5069142482

   @rok I have added `-Dsimdjson_SOURCE=BUNDLED` to `ci/scripts/python_wheel_windows_build.bat`. Could you please re-run the Crossbow jobs to verify the fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5063172162

   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5065498861

   Can we disable `ARROW_JSON` and `ARROW_WITH_SIMDJSON` forcibly with AppleClang 21 or older?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50587:
URL: https://github.com/apache/arrow/pull/50587#discussion_r3643152174


##########
r/inst/build_arrow_static.sh:
##########
@@ -107,8 +107,9 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
     -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
     -DOPENSSL_ROOT_DIR=${OPENSSL_ROOT_DIR} \
-    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
     -Dabsl_SOURCE=${absl_SOURCE:-BUNDLED} \
+    -Dre2_SOURCE=${re2_SOURCE:-BUNDLED} \
+    -Dsimdjson_SOURCE=${simdjson_SOURCE:-} \

Review Comment:
   Removed changes in `r/tootls/nixlibs.R`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5069050327

   I think this is because `ARROW_DEPENDENCY_SOURCE=VCPKG` and the build image doesn't yet have simdjson? We could temporarily fix the windows wheel nightlies in this PR with:
   
   ```diff
   diff --git a/ci/scripts/python_wheel_windows_build.bat b/ci/scripts/python_wheel_windows_build.bat
   --- a/ci/scripts/python_wheel_windows_build.bat
   +++ b/ci/scripts/python_wheel_windows_build.bat
    @@ -107,6 +107,7 @@ cmake ^
        -DPARQUET_REQUIRE_ENCRYPTION=%PARQUET_REQUIRE_ENCRYPTION% ^
        -DVCPKG_MANIFEST_MODE=OFF ^
        -DVCPKG_TARGET_TRIPLET=%VCPKG_TARGET_TRIPLET% ^
   +    -Dsimdjson_SOURCE=BUNDLED ^
        -Dxsimd_SOURCE=BUNDLED ^
        -G "%CMAKE_GENERATOR%" ^
        -A "%CMAKE_PLATFORM%" ^
   ```
   
   We could also update the python wheel windows image to install simdjson, but that would better fit into a followup PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50587:
URL: https://github.com/apache/arrow/pull/50587#issuecomment-5069448740

   @github-actions crossbow submit wheel-windows-cp314-cp314t-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50581: [C++][R] Use bundled simdjson for C++ wrapper builds [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok merged PR #50587:
URL: https://github.com/apache/arrow/pull/50587


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org