You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/02/07 09:40:11 UTC

[GitHub] [thrift] emmenlau commented on pull request #2318: THRIFT-5341: Fix Old-Style-Cast, Missing override and Possible noexcept

emmenlau commented on pull request #2318:
URL: https://github.com/apache/thrift/pull/2318#issuecomment-774643308


   Dear @kashirin-alex , the changes you did look valuable, thanks for this contribution! I would like to review them more thoroughly but its not a trivial change and I would need significantly more time for a good review. If somebody else can jump in thats great, otherwise I may find some time in the next months (but not in the short term, sorry).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org