You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/17 04:08:17 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #815: [DRAFT] Integrate with code-mirrot to have a fallback for plugins' issue
juzhiyuan opened a new issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815
TODO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730796709
> I think this proposal is a good compromise.
> We can improve the documentation to increase the experience, we can try to provide some **configuration template** for common scenarios, then users can use our plugin by copying the template and modifying some configuration parameters.
Than
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-731909525
ok, then I'm going to do this this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730827863
> > will the editor highlights the error to help the user to rectify it?
>
> Not sure, if CodeMirror supports it, we will add this feature.
> BTW, the frontend will validate the data according to schema before sending APIs.
I think the feeling of interaction is important, some low level syntax errors are not so easy to found especially when the plugin data is fairly long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730265425
Please take a look at this proposal, though it's not very friendly for users to input JSON, it works for all the plugins.
cc @liuxiran @LiteSun @moonming @membphis @ShiningRush @idbeta
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-737939476
got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-732635180
This issue is related to those issues.
#764
#802
#812
#814
#790
#788
#762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-735387056
After some research and trying, I find that we should add a Format button instead of auto-formatting because auto-formatting will make the input Textarea lost focus.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-735612207
> After some research and trying, I find that we should add a Format button instead of auto-formatting because auto-formatting will make the input Textarea lost focus.
agree ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-735387056
After some research and trying, I find that we should add a Format button instead of auto-formatting because auto-formatting will make the input Textarea lost focus.
cc @liuxiran @moonming @membphis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730266808
We will use [CodeMirror](https://codemirror.net/) to highlight the json data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-731909525
ok, then I'm going to do this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730273471
> Agree, need to provide users with JSONschema examples of each plugin, you can add a link next to the plugin to make it easier for users to find these examples.
Ya, a quick way is adding a link to that plugin's doc 😂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-737816037
ping @membphis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730825573
> will the editor highlights the error to help the user to rectify it?
Not sure, if CodeMirror supports it, we will add this feature.
BTW, the frontend will validate the data according to schema before sending APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730796296
I think this proposal is a good compromise.
We can improve the documentation to increase the experience, we can try to provide some **configuration template** for common scenarios, then users can use our plugin by copying the template and modifying some configuration parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730825573
> will the editor highlights the error to help the user to rectify it?
Not sure, if CodeMirror supports it, we will add this feature.
BTW, the frontend will validate the data according to schema before sending APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730265425
Please take a look at this proposal, though it's not very friendly for users to input JSON, it works for all the plugins.
cc @liuxiran @LiteSun @moonming @membphis @ShiningRush @idbeta @tokers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730796709
> I think this proposal is a good compromise.
> We can improve the documentation to increase the experience, we can try to provide some **configuration template** for common scenarios, then users can use our plugin by copying the template and modifying some configuration parameters.
That's it!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730880519
> > > will the editor highlights the error to help the user to rectify it?
> >
> > Not sure, if CodeMirror supports it, we will add this feature.
> > BTW, the frontend will validate the data according to schema before sending APIs.
>
> I think the feeling of interaction is important, some low level syntax errors are not so easy to found especially when the plugin data is fairly long.
Got it, we support validating with jsonschema, errors will show up if there has something incompatible with schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-735387225
When users input or paste some JSON codes here, they could click the format button to achieve code format, easy to implement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-735516038
Snapshot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730272910
Agree, need to provide users with JSONschema examples of each plugin, you can add a link next to the plugin to make it easier for users to find these examples.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730813433
I have just one question, is the plugin data editor friendly enough? say user puts some unexpected characters accidently (like adding extra commas)
will the editor highlights the error to help user to rectify it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #815:
URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-730797061
> > I think this proposal is a good compromise.
> > We can improve the documentation to increase the experience, we can try to provide some **configuration template** for common scenarios, then users can use our plugin by copying the template and modifying some configuration parameters.
>
> That's it!!
and this may be easier to use than visual forms :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org