You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/04/06 03:52:14 UTC

[GitHub] [iceberg] aokolnychyi opened a new issue #2423: Why createParquetAsIceberg is true in IcebergSource?

aokolnychyi opened a new issue #2423:
URL: https://github.com/apache/iceberg/issues/2423


   I am wondering why `parquet-enabled` is true when we set up a default Iceberg catalog in `IcebergSource`. That's a different default value than what we usually use. Any particular reason?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rymurr commented on issue #2423: Why createParquetAsIceberg is true in IcebergSource?

Posted by GitBox <gi...@apache.org>.
rymurr commented on issue #2423:
URL: https://github.com/apache/iceberg/issues/2423#issuecomment-814065057


   Hey @aokolnychyi, from my reading that is an oversight/copy-paste error. I personally think it should be removed.
   
   It appears that the parameter goes unused by default correct? The `IcebergSource` sets up the default_iceberg catalog as a `SparkCatalog` with that parameter set and `SparkCatalog` doesn't use it. It could have strange effects if the default catalog was switched to a session catalog though....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] aokolnychyi commented on issue #2423: Why createParquetAsIceberg is true in IcebergSource?

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on issue #2423:
URL: https://github.com/apache/iceberg/issues/2423#issuecomment-813802162


   cc @rdblue @rymurr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] aokolnychyi commented on issue #2423: Why createParquetAsIceberg is true in IcebergSource?

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on issue #2423:
URL: https://github.com/apache/iceberg/issues/2423#issuecomment-814447798


   I don't think it causes any issues right now but I think we should remove it to avoid any surprises in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] aokolnychyi closed issue #2423: Why createParquetAsIceberg is true in IcebergSource?

Posted by GitBox <gi...@apache.org>.
aokolnychyi closed issue #2423:
URL: https://github.com/apache/iceberg/issues/2423


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org