[PR] Avoid using function closures in mem3 [couchdb]

["nickva (via GitHub)" <gi...@apache.org>]

nickva opened a new pull request, #5712:
URL: https://github.com/apache/couchdb/pull/5712

   Those are for debugging in remsh but still function closure are fragile when sent between nodes so avoid them and rely on the new erpc module with plain M, F, A args.
   
   While at it, improve `dead_nodes/0,1` function. Make it return the node from whose perspective we noticed the dead nodes. That makes it a bit more clear what the network partitioned might be look like.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Avoid using function closures in mem3 [couchdb]

["nickva (via GitHub)" <gi...@apache.org>]

nickva commented on PR #5712:
URL: https://github.com/apache/couchdb/pull/5712#issuecomment-3438970922

   On way to test it might be to start a local 3 node cluster then disconnect some nodes:
   
   ```
   (node2@127.0.0.1)3> net_kernel:disconnect('node3@127.0.0.1').
   true
   (node2@127.0.0.1)4> nodes().
   ['node1@127.0.0.1']
   (node2@127.0.0.1)5> nodes().
   ['node1@127.0.0.1']
   (node2@127.0.0.1)6> mem3:dead_nodes().
   [{'node2@127.0.0.1',['node3@127.0.0.1']}]
   ```
   
   ```
   (node1@127.0.0.1)7> mem3:dead_nodes().
   [{'node2@127.0.0.1',['node3@127.0.0.1']},
    {'node3@127.0.0.1',['node2@127.0.0.1']}]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Avoid using function closures in mem3 [couchdb]

["nickva (via GitHub)" <gi...@apache.org>]

nickva merged PR #5712:
URL: https://github.com/apache/couchdb/pull/5712


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org