You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/29 09:23:20 UTC
[GitHub] [spark] gaoyajun02 opened a new pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
gaoyajun02 opened a new pull request #33131:
URL: https://github.com/apache/spark/pull/33131
### What changes were proposed in this pull request?
Fix Kryo Shaded dependency for build
### Why are the changes needed?
I found that the build failed when I ran the unit test. Spark lost the kryo-shaded dependency after updating Chill recently.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33131:
URL: https://github.com/apache/spark/pull/33131#discussion_r660776009
##########
File path: core/pom.xml
##########
@@ -33,7 +33,7 @@
<properties>
<sbt.project.name>core</sbt.project.name>
</properties>
-
+
Review comment:
Let's not touch irrelevant file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33131:
URL: https://github.com/apache/spark/pull/33131#discussion_r660777507
##########
File path: common/unsafe/pom.xml
##########
@@ -56,6 +56,11 @@
<artifactId>chill_${scala.binary.version}</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.esotericsoftware</groupId>
+ <artifactId>kryo-shaded</artifactId>
+ </dependency>
Review comment:
Is this the missed dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33131:
URL: https://github.com/apache/spark/pull/33131#issuecomment-870816136
Maven build also looks good to me.
```
$ build/mvn package -pl common/unsafe --am
...
[INFO] Spark Project Parent POM ........................... SUCCESS [ 2.082 s]
[INFO] Spark Project Tags ................................. SUCCESS [ 3.866 s]
[INFO] Spark Project Unsafe ............................... SUCCESS [ 6.463 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12.878 s
[INFO] Finished at: 2021-06-29T11:21:11-07:00
[INFO] ------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33131:
URL: https://github.com/apache/spark/pull/33131#issuecomment-870742689
FYI, in the master branch, I can test the module without this PR.
```
$ build/sbt "unsafe/test"
...
[info] Run completed in 1 second, 56 milliseconds.
[info] Total number of tests run: 19
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 19, failed 0, canceled 0, ignored 1, pending 0
[info] All tests passed.
[info] Passed: Total 76, Failed 0, Errors 0, Passed 76, Ignored 1
[success] Total time: 5 s, completed Jun 29, 2021 9:24:30 AM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33131:
URL: https://github.com/apache/spark/pull/33131#issuecomment-870739505
Thank you for making a PR. The GitHub Action works fine. Could you add how to reproduce the failure into the PR description?
> I found that the build failed when I ran the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaoyajun02 edited a comment on pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
gaoyajun02 edited a comment on pull request #33131:
URL: https://github.com/apache/spark/pull/33131#issuecomment-871047161
I'm very sorry, when I executed the unit test today, there were no errors. I will close this PR.
I have located the problem, because I am using my company's maven repository. Yesterday, the chill-java-0.10.0.pom dependency was not updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33131:
URL: https://github.com/apache/spark/pull/33131#discussion_r660776280
##########
File path: pom.xml
##########
@@ -3317,9 +3322,9 @@
<profile>
<id>scala-2.12</id>
<properties>
- <!--
+ <!--
SPARK-34774 Add this property to ensure change-scala-version.sh can replace the public `scala.version`
- property correctly.
+ property correctly.
Review comment:
Let's not change the irrelevant part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33131:
URL: https://github.com/apache/spark/pull/33131#issuecomment-870712325
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33131:
URL: https://github.com/apache/spark/pull/33131#issuecomment-871086897
Thank you for the confirmation, @gaoyajun02 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #33131:
URL: https://github.com/apache/spark/pull/33131#issuecomment-870742689
FYI, in the master branch, I can test the module without this PR. Given that, `unsafe` module is not broken at least. Which module did you hit the failure?
```
$ build/sbt "unsafe/test"
...
[info] Run completed in 1 second, 56 milliseconds.
[info] Total number of tests run: 19
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 19, failed 0, canceled 0, ignored 1, pending 0
[info] All tests passed.
[info] Passed: Total 76, Failed 0, Errors 0, Passed 76, Ignored 1
[success] Total time: 5 s, completed Jun 29, 2021 9:24:30 AM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaoyajun02 commented on pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
gaoyajun02 commented on pull request #33131:
URL: https://github.com/apache/spark/pull/33131#issuecomment-871047161
I'm very sorry, when I executed the unit test today, there were no errors. I will close this PR.
I have located the problem, because I am using my company's mvn mirror warehouse. Yesterday, the chill-java-0.10.0.pom dependency was not updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaoyajun02 closed pull request #33131: [SPARK-35920][FOLLOWUP][BUILD] Fix Kryo Shaded dependency
Posted by GitBox <gi...@apache.org>.
gaoyajun02 closed pull request #33131:
URL: https://github.com/apache/spark/pull/33131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org