You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/26 11:59:07 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #23107: Refactor PipelineChangedJobConfigurationProcessor.process parameter
sandynz opened a new pull request, #23107:
URL: https://github.com/apache/shardingsphere/pull/23107
Changes proposed in this pull request:
- Replace `DataChangedEvent.Type` to `Type`
- Replace `JobConfigurationPOJO` to `JobConfiguration`
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23107: Refactor PipelineChangedJobConfigurationProcessor.process parameter
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23107:
URL: https://github.com/apache/shardingsphere/pull/23107#issuecomment-1365138098
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23107](https://codecov.io/gh/apache/shardingsphere/pull/23107?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (14bc9a2) into [master](https://codecov.io/gh/apache/shardingsphere/commit/aac4039e5dba69b34fcae9a5c6d2ed9261151597?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aac4039) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #23107 +/- ##
=========================================
Coverage 49.95% 49.95%
Complexity 2433 2433
=========================================
Files 4112 4112
Lines 57482 57482
Branches 9082 9082
=========================================
Hits 28717 28717
Misses 26254 26254
Partials 2511 2511
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...andler/impl/ChangedJobConfigurationDispatcher.java](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL21ldGFkYXRhL25vZGUvZXZlbnQvaGFuZGxlci9pbXBsL0NoYW5nZWRKb2JDb25maWd1cmF0aW9uRGlzcGF0Y2hlci5qYXZh) | `16.66% <0.00%> (ø)` | |
| [...sistencyCheckChangedJobConfigurationProcessor.java](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvc2NlbmFyaW8vY29uc2lzdGVuY3ljaGVjay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9jb25zaXN0ZW5jeWNoZWNrL21ldGFkYXRhL3Byb2Nlc3Nvci9Db25zaXN0ZW5jeUNoZWNrQ2hhbmdlZEpvYkNvbmZpZ3VyYXRpb25Qcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...sor/MigrationChangedJobConfigurationProcessor.java](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvc2NlbmFyaW8vbWlncmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL21pZ3JhdGlvbi9tZXRhZGF0YS9wcm9jZXNzb3IvTWlncmF0aW9uQ2hhbmdlZEpvYkNvbmZpZ3VyYXRpb25Qcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../transformer/builder/advise/JDBCAdviceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS90cmFuc2Zvcm1lci9idWlsZGVyL2FkdmlzZS9KREJDQWR2aWNlRmFjdG9yeS5qYXZh) | | |
| [...re/config/yaml/entity/YamlPluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9lbnRpdHkvWWFtbFBsdWdpbkNvbmZpZ3VyYXRpb24uamF2YQ==) | | |
| [...ardingsphere/agent/core/logging/LoggerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9sb2dnaW5nL0xvZ2dlckZhY3RvcnkuamF2YQ==) | | |
| [...g/yaml/entity/YamlPluginCategoryConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9lbnRpdHkvWWFtbFBsdWdpbkNhdGVnb3J5Q29uZmlndXJhdGlvbi5qYXZh) | | |
| [...e/shardingsphere/agent/core/util/TimeRecorder.java](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS91dGlsL1RpbWVSZWNvcmRlci5qYXZh) | | |
| [.../yaml/swapper/YamlPluginsConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9zd2FwcGVyL1lhbWxQbHVnaW5zQ29uZmlndXJhdGlvblN3YXBwZXIuamF2YQ==) | | |
| [.../plugin/yaml/entity/YamlPointcutConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4veWFtbC9lbnRpdHkvWWFtbFBvaW50Y3V0Q29uZmlndXJhdGlvbi5qYXZh) | | |
| ... and [67 more](https://codecov.io/gh/apache/shardingsphere/pull/23107/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #23107: Refactor PipelineChangedJobConfigurationProcessor.process parameter
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #23107:
URL: https://github.com/apache/shardingsphere/pull/23107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org