You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/06/10 17:30:59 UTC

[GitHub] [activemq-artemis] jbertram commented on pull request #3618: ARTEMIS-3341: update checkstyle, use consistent plugin version

jbertram commented on pull request #3618:
URL: https://github.com/apache/activemq-artemis/pull/3618#issuecomment-858816830


   Why not use this in `checkstyle.xml`:
   ```xml
         <module name="RightCurly">
            <property name="option" value="alone_or_singleline"/>
            <property name="tokens" value="METHOD_DEF, CTOR_DEF"/>
         </module>
   ```
   Then you could drop your changes from `TypedProperties` and `AbstractJDBCDriver` and everything would be consistent.
   
   As it stands now the change looks a bit strange because you're eliminating a newline in `SensitiveDataCodec` and adding one in the other two aforementioned classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org