You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/07/17 19:00:31 UTC
Review Request 60917: Used a real UPID to send `LearnedMessage`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60917/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Repository: mesos
Description
-------
Previously an empty UPID `@0.0.0.0:0` was used which could result in
the message being dropped due to certain security check (MESOS-7401).
Diffs
-----
src/log/network.hpp 0afcfae27394527f7c957e31014cc9a32a4bf63b
Diff: https://reviews.apache.org/r/60917/diff/1/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 60917: Used a real UPID to send `LearnedMessage`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60917/#review180726
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60917]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 17, 2017, 3 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60917/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 3 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7753
> https://issues.apache.org/jira/browse/MESOS-7753
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously an empty UPID `@0.0.0.0:0` was used which could result in
> the message being dropped due to certain security check (MESOS-7401).
>
>
> Diffs
> -----
>
> src/log/network.hpp 0afcfae27394527f7c957e31014cc9a32a4bf63b
>
>
> Diff: https://reviews.apache.org/r/60917/diff/1/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 60917: Used a real UPID to send `LearnedMessage`.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On July 17, 2017, 5:37 p.m., Joseph Wu wrote:
> > src/log/network.hpp
> > Line 247 (original), 248-250 (patched)
> > <https://reviews.apache.org/r/60917/diff/1/?file=1777905#file1777905line248>
> >
> > I'd prefer this comment to be a `NOTE: ...`
> >
> > :)
Sure :)
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60917/#review180773
-----------------------------------------------------------
On July 17, 2017, noon, Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60917/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, noon)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7753
> https://issues.apache.org/jira/browse/MESOS-7753
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously an empty UPID `@0.0.0.0:0` was used which could result in
> the message being dropped due to certain security check (MESOS-7401).
>
>
> Diffs
> -----
>
> src/log/network.hpp 0afcfae27394527f7c957e31014cc9a32a4bf63b
>
>
> Diff: https://reviews.apache.org/r/60917/diff/1/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 60917: Used a real UPID to send `LearnedMessage`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60917/#review180773
-----------------------------------------------------------
Ship it!
LGTM.
src/log/network.hpp
Line 247 (original), 248-250 (patched)
<https://reviews.apache.org/r/60917/#comment255997>
I'd prefer this comment to be a `NOTE: ...`
:)
- Joseph Wu
On July 17, 2017, noon, Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60917/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, noon)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7753
> https://issues.apache.org/jira/browse/MESOS-7753
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously an empty UPID `@0.0.0.0:0` was used which could result in
> the message being dropped due to certain security check (MESOS-7401).
>
>
> Diffs
> -----
>
> src/log/network.hpp 0afcfae27394527f7c957e31014cc9a32a4bf63b
>
>
> Diff: https://reviews.apache.org/r/60917/diff/1/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>