[jira] [Commented] (FLUME-1373) Remove hardcoded file separator in HDFSEventSink

["Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415002#comment-13415002 ] 

Jarek Jarcec Cecho commented on FLUME-1373:
-------------------------------------------

Hi Mubarak,
do you have use case where you had issues and this change solve them?

I was exploring the source code and the "path" variable seems to be used only for HDFS access. I'm not sure whether hdfs will actually support windows file separator (even when running on windows).

Jarcec
                
> Remove hardcoded file separator in HDFSEventSink
> ------------------------------------------------
>
>                 Key: FLUME-1373
>                 URL: https://issues.apache.org/jira/browse/FLUME-1373
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>            Reporter: Mubarak Seyed
>            Priority: Trivial
>         Attachments: FLUME-1373.trunk.v1.patch
>
>
> configure() in HDFSEventSink hardcodes the file separator
> {code}
>     // FIXME: Not portable to Windows
>     this.path = dirpath + "/" + fileName;
> {code}
> Fix is very simple, just to use 
> {code}
>     this.path = dirpath + System.getProperty("file.separator") + fileName;
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira