You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Always-prog (via GitHub)" <gi...@apache.org> on 2023/08/23 16:30:06 UTC
[GitHub] [superset] Always-prog opened a new pull request, #24008: fix(table): condition formatting can't formate 0 values
Always-prog opened a new pull request, #24008:
URL: https://github.com/apache/superset/pull/24008
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Conditional formatting was not working for cells with value 0. This PR fixes the issue.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### Before
#### After
### TESTING INSTRUCTIONS
1. Create a table chart.
2. Create a metric from SQL `(0)`.
3. Add a condition for the metric.
4. The don't condition works for cells with value 0.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #24008: fix(table): condition formatting can't formate 0 values
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24008:
URL: https://github.com/apache/superset/pull/24008#issuecomment-1690273708
Closing and re-opening in order to kick-start CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #24008: fix(table): condition formatting can't formate 0 values
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #24008: fix(table): condition formatting can't formate 0 values
URL: https://github.com/apache/superset/pull/24008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24008: fix(table): condition formatting can't formate 0 values
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24008:
URL: https://github.com/apache/superset/pull/24008#issuecomment-1542715015
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24008?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24008](https://app.codecov.io/gh/apache/superset/pull/24008?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a668fa) into [master](https://app.codecov.io/gh/apache/superset/commit/7757b61c22da1139cc32a060d06dc0417b9b5f28?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7757b61) will **decrease** coverage by `0.06%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 7a668fa differs from pull request most recent head 1741041. Consider uploading reports for the commit 1741041 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24008 +/- ##
==========================================
- Coverage 68.19% 68.13% -0.06%
==========================================
Files 1941 1941
Lines 75277 75304 +27
Branches 8166 8166
==========================================
- Hits 51333 51308 -25
- Misses 21855 21907 +52
Partials 2089 2089
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `54.55% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24008?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/plugins/plugin-chart-table/src/TableChart.tsx](https://app.codecov.io/gh/apache/superset/pull/24008?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL1RhYmxlQ2hhcnQudHN4) | `44.91% <100.00%> (ø)` | |
| [superset/views/core.py](https://app.codecov.io/gh/apache/superset/pull/24008?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.38% <100.00%> (+0.25%)` | :arrow_up: |
... and [19 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24008/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Always-prog commented on pull request #24008: fix(table): condition formatting can't formate 0 values
Posted by "Always-prog (via GitHub)" <gi...@apache.org>.
Always-prog commented on PR #24008:
URL: https://github.com/apache/superset/pull/24008#issuecomment-1691072474
Thanks for taking a look, @rusackas! It seems that all CI tests have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #24008: fix(table): condition formatting can't formate 0 values
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #24008:
URL: https://github.com/apache/superset/pull/24008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org