You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/03 14:52:23 UTC
[GitHub] [arrow] nirandaperera commented on a change in pull request #11886: ARROW-13035: [C++] indices_nonzero compute function
nirandaperera commented on a change in pull request #11886:
URL: https://github.com/apache/arrow/pull/11886#discussion_r777521811
##########
File path: cpp/src/arrow/compute/kernels/vector_selection_test.cc
##########
@@ -2328,5 +2328,40 @@ TEST_F(TestDropNullKernelWithTable, DropNullTableWithSlices) {
});
}
+TEST(TestIndicesNonZero, IndicesNonZero) {
+ Datum actual;
+ std::shared_ptr<Array> result;
+
+ ASSERT_OK_AND_ASSIGN(
+ actual,
+ CallFunction("indices_nonzero", {ArrayFromJSON(uint32(), "[null, 50, 0, 10]")}));
+ result = actual.make_array();
+ AssertArraysEqual(*result, *ArrayFromJSON(uint64(), "[1, 3]"));
+
+ ASSERT_OK_AND_ASSIGN(
+ actual, CallFunction("indices_nonzero",
+ {ArrayFromJSON(boolean(), "[null, true, false, true]")}));
+ result = actual.make_array();
+ AssertArraysEqual(*result, *ArrayFromJSON(uint64(), "[1, 3]"));
+
+ ASSERT_OK_AND_ASSIGN(actual,
+ CallFunction("indices_nonzero",
+ {ArrayFromJSON(float64(), "[null, 1.3, 0.0, 5.0]")}));
+ result = actual.make_array();
+ AssertArraysEqual(*result, *ArrayFromJSON(uint64(), "[1, 3]"));
+
+ ASSERT_OK_AND_ASSIGN(actual,
+ CallFunction("indices_nonzero", {ArrayFromJSON(float64(), "[]")}));
+ result = actual.make_array();
+ AssertArraysEqual(*result, *ArrayFromJSON(uint64(), "[]"));
+
+ ChunkedArray chunkedarr(
+ {ArrayFromJSON(uint32(), "[1, 0, 3]"), ArrayFromJSON(uint32(), "[4, 0, 6]")});
+ ASSERT_OK_AND_ASSIGN(actual,
+ CallFunction("indices_nonzero", {static_cast<Datum>(chunkedarr)}));
+ Datum expected = ChunkedArrayFromJSON(uint64(), {R"([0, 2])", R"([0, 2])"});
Review comment:
coming to think of it, shouldnt the expected be, `[0, 2, 3, 5]` as a single array? :thinking: I believe that's how chunked arrays are indexed (subsequent chunks are offset with the prefix sum) AFAIU.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org