You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Geir Magnusson Jr (JIRA)" <ji...@apache.org> on 2006/03/21 13:28:58 UTC
[jira] Resolved: (HARMONY-31) Move peformance timing of unit tests
into a decorator class.
[ http://issues.apache.org/jira/browse/HARMONY-31?page=all ]
Geir Magnusson Jr resolved HARMONY-31:
--------------------------------------
Resolution: Won't Fix
This has been taken care of elsewhere, IIRC. Resolving for now to see if there's howls of protest...
> Move peformance timing of unit tests into a decorator class.
> ------------------------------------------------------------
>
> Key: HARMONY-31
> URL: http://issues.apache.org/jira/browse/HARMONY-31
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: George Harley
> Assignee: Geir Magnusson Jr
> Priority: Minor
> Attachments: PerfDecorator.java
>
> There has been some low-level discussion on the dev mailing list recently about the inclusion of performance-related logging code near the top of a unit test class inheritance hierarchy (see com.openintel.drl.security.test.PerformanceTest in the HARMONY-16 contribution). This particular issue suggests an alternative way of adding in timing code but without making it the responsibility of the unit tests themselves and without the need to introduce a class in the inheritance hierarchy.
> The basic approach is to exploit the junit.extensions.TestDecorator type in the JUnit API to add in timing behaviour before and after each test method runs. This will be demonstrated with some simple sample code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Resolved: (HARMONY-31) Move peformance timing of unit
tests into a decorator class.
Posted by Geir Magnusson Jr <ge...@pobox.com>.
George Harley wrote:
> Geir Magnusson Jr wrote:
>>
>> Do you think this should be re-opened, or an new JIRA created to keep
>> things clear?
>>
>> geir
>
> Hi,
>
> My vote is to keep it closed since the original issue has gone away.
Is there something you want to recover from it that adds functionality?
geir
Re: [jira] Resolved: (HARMONY-31) Move peformance timing of unit
tests into a decorator class.
Posted by George Harley <ge...@googlemail.com>.
Geir Magnusson Jr wrote:
>
>
> George Harley wrote:
>> Geir Magnusson Jr wrote:
>>>
>>>
>>> Tim Ellison wrote:
>>>> I know that you'll be disappointed if I didn't ...
>>>>
>>>> Geir Magnusson Jr (JIRA) wrote:
>>>> <snip>
>>>>> Resolution: Won't Fix
>>>>>
>>>>> This has been taken care of elsewhere, IIRC. Resolving for now to
>>>>> see if there's howls of protest...
>>>>
>>>> How was it resolved?
>>>
>>> I thought there was a patch that removed it. If there wasn't, happy
>>> to re-open.
>>>
>>> geir
>>
>> Hi Geir,
>>
>> Is this what you mean ?
>> http://issues.apache.org/jira/browse/HARMONY-55?page=all
>>
>> Personally, I think that HARMONY-31 was awesome :-)
>
> We all do George!
>
>> At least the basic principle of pushing the auxiliary functionality
>> (in this case timing) up to the test framework is there in the sample
>> code attachment if anyone else is keen to do more in this area.
>
> Do you think this should be re-opened, or an new JIRA created to keep
> things clear?
>
> geir
Hi,
My vote is to keep it closed since the original issue has gone away.
Best regards,
George
>
>>
>> Best regards,
>> George
>>
>>>
>>>>
>>>> Regards,
>>>> Tim
>>>>
>>>
>>
>>
>
Re: [jira] Resolved: (HARMONY-31) Move peformance timing of unit
tests into a decorator class.
Posted by Geir Magnusson Jr <ge...@pobox.com>.
George Harley wrote:
> Geir Magnusson Jr wrote:
>>
>>
>> Tim Ellison wrote:
>>> I know that you'll be disappointed if I didn't ...
>>>
>>> Geir Magnusson Jr (JIRA) wrote:
>>> <snip>
>>>> Resolution: Won't Fix
>>>>
>>>> This has been taken care of elsewhere, IIRC. Resolving for now to
>>>> see if there's howls of protest...
>>>
>>> How was it resolved?
>>
>> I thought there was a patch that removed it. If there wasn't, happy
>> to re-open.
>>
>> geir
>
> Hi Geir,
>
> Is this what you mean ?
> http://issues.apache.org/jira/browse/HARMONY-55?page=all
>
> Personally, I think that HARMONY-31 was awesome :-)
We all do George!
> At least the basic
> principle of pushing the auxiliary functionality (in this case timing)
> up to the test framework is there in the sample code attachment if
> anyone else is keen to do more in this area.
Do you think this should be re-opened, or an new JIRA created to keep
things clear?
geir
>
> Best regards,
> George
>
>>
>>>
>>> Regards,
>>> Tim
>>>
>>
>
>
Re: [jira] Resolved: (HARMONY-31) Move peformance timing of unit
tests into a decorator class.
Posted by George Harley <ge...@googlemail.com>.
Geir Magnusson Jr wrote:
>
>
> Tim Ellison wrote:
>> I know that you'll be disappointed if I didn't ...
>>
>> Geir Magnusson Jr (JIRA) wrote:
>> <snip>
>>> Resolution: Won't Fix
>>>
>>> This has been taken care of elsewhere, IIRC. Resolving for now to
>>> see if there's howls of protest...
>>
>> How was it resolved?
>
> I thought there was a patch that removed it. If there wasn't, happy
> to re-open.
>
> geir
Hi Geir,
Is this what you mean ?
http://issues.apache.org/jira/browse/HARMONY-55?page=all
Personally, I think that HARMONY-31 was awesome :-) At least the basic
principle of pushing the auxiliary functionality (in this case timing)
up to the test framework is there in the sample code attachment if
anyone else is keen to do more in this area.
Best regards,
George
>
>>
>> Regards,
>> Tim
>>
>
Re: [jira] Resolved: (HARMONY-31) Move peformance timing of unit
tests into a decorator class.
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Tim Ellison wrote:
> I know that you'll be disappointed if I didn't ...
>
> Geir Magnusson Jr (JIRA) wrote:
> <snip>
>> Resolution: Won't Fix
>>
>> This has been taken care of elsewhere, IIRC. Resolving for now to see if there's howls of protest...
>
> How was it resolved?
I thought there was a patch that removed it. If there wasn't, happy to
re-open.
geir
>
> Regards,
> Tim
>
Re: [jira] Resolved: (HARMONY-31) Move peformance timing of unit
tests into a decorator class.
Posted by Tim Ellison <t....@gmail.com>.
I know that you'll be disappointed if I didn't ...
Geir Magnusson Jr (JIRA) wrote:
<snip>
> Resolution: Won't Fix
>
> This has been taken care of elsewhere, IIRC. Resolving for now to see if there's howls of protest...
How was it resolved?
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.