You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "balesh2 (GitHub)" <gi...@apache.org> on 2019/02/22 00:02:59 UTC
[GitHub] [geode] balesh2 opened pull request #3220: GEODE-6440:
synchronize when getting and setting
Synchronize on getting and setting stats to avoid a race condition that
could occur when multiple threads were trying to set gauge stats.
Signed-off-by: Jacob Barrett <jb...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3220 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] balesh2 closed pull request #3220: GEODE-6440:
synchronize when getting and setting
Posted by "balesh2 (GitHub)" <gi...@apache.org>.
[ pull request closed by balesh2 ]
[ Full content available at: https://github.com/apache/geode/pull/3220 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] balesh2 commented on issue #3220: GEODE-6440:
synchronize when getting and setting
Posted by "balesh2 (GitHub)" <gi...@apache.org>.
DistributedTestOpenJDK8 failed due to known flaky test https://issues.apache.org/jira/browse/GEODE-6437
[ Full content available at: https://github.com/apache/geode/pull/3220 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on issue #3220:
GEODE-6440: synchronize when getting and setting
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Yes, gauges will be just as slow as the old implementation until we refactor to support different storage classes for each type of metric.
[ Full content available at: https://github.com/apache/geode/pull/3220 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org