You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "pcfriek1987 (via GitHub)" <gi...@apache.org> on 2024/04/29 15:16:56 UTC
[I] Webgui SSL import does not check on root certificate [cloudstack]
pcfriek1987 opened a new issue, #9004:
URL: https://github.com/apache/cloudstack/issues/9004
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
UI
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
4.19.0.1
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
N/A
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
N/A
##### SUMMARY
<!-- Explain the problem/feature briefly -->
Uploading an invalid root certificate doesn't error out.
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
Using the portal -> Infrastructure -> Summary -> SSL Certificates.
Upload a root certificate but do not paste the:
-----END CERTIFICATE----
Fill in the rest correctly like the certificate and key.
Then Submit it.
It will try reloading the secondary storage and console proxy but the console proxy will never have it's agent connected again without the correct root certificate.
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
To get an error the root certificate is not correct.
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
It went through without errors, but mentioned an incomplete certfificate in the management log when the consoleproxy agent tries to connect.
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Webgui SSL import does not check on root certificate [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on issue #9004:
URL: https://github.com/apache/cloudstack/issues/9004#issuecomment-2303638287
Thanks @pcfriek1987 added a check for the root certificate in my PR, that should fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Webgui SSL import does not check on root certificate [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on issue #9004:
URL: https://github.com/apache/cloudstack/issues/9004#issuecomment-2175222944
@pcfriek1987 I've tried to reproduce the scenario by uploading the incomplete certificate but I'm getting the validation error like below
I've uploaded the certificate from here by providing these example values
Can you please confirm or tell us what you've tried
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Webgui SSL import does not check on root certificate [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on issue #9004:
URL: https://github.com/apache/cloudstack/issues/9004#issuecomment-2090517387
Thanks for sharing @pcfriek1987 there isn’t a functional issue though the certificate validation could have been improved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Webgui SSL import does not check on root certificate [cloudstack]
Posted by "pcfriek1987 (via GitHub)" <gi...@apache.org>.
pcfriek1987 commented on issue #9004:
URL: https://github.com/apache/cloudstack/issues/9004#issuecomment-2090400658
Hi Daan,
Afters hours I found out that it's certificate was incomplete, after uploading the correct one it started working, so uploading the correct one works as it should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Webgui SSL import does not check on root certificate [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed issue #9004: Webgui SSL import does not check on root certificate
URL: https://github.com/apache/cloudstack/issues/9004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Webgui SSL import does not check on root certificate [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #9004:
URL: https://github.com/apache/cloudstack/issues/9004#issuecomment-2090395336
@pcfriek1987 , can you re-upload the certificate without error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Webgui SSL import does not check on root certificate [cloudstack]
Posted by "pcfriek1987 (via GitHub)" <gi...@apache.org>.
pcfriek1987 commented on issue #9004:
URL: https://github.com/apache/cloudstack/issues/9004#issuecomment-2175534453
@harikrishna-patnala For me it was only the root certificate, the other 2 we're already correct. Only the root certificate had the end certificate part missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Webgui SSL import does not check on root certificate [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #9004:
URL: https://github.com/apache/cloudstack/issues/9004#issuecomment-2314828328
fixed in #9255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org