[GitHub] [flink] pnowojski commented on a change in pull request #12173: [FLINK-17727][task] don't create output stream with no channel state (unaligned checkpoints)

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #12173:
URL: https://github.com/apache/flink/pull/12173#discussion_r425849216



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateCheckpointWriter.java
##########
@@ -150,6 +151,12 @@ private void complete(boolean precondition, RunnableWithException complete) thro
 	}
 
 	private void finishWriteAndResult() throws IOException {
+		if (inputChannelOffsets.isEmpty() && resultSubpartitionOffsets.isEmpty()) {
+			dataStream.close();
+			result.inputChannelStateHandles.complete(emptyList());
+			result.resultSubpartitionStateHandles.complete(emptyList());
+			return;
+		}

Review comment:
       Don't we have to clean up/remove some empty file? I guess in this branch, `dataStream` will be empty and we have already created some file for it? In other words, won't this code leave a lingering empty files somewhere?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org