You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/10/19 17:01:20 UTC
[GitHub] [hive] zabetak opened a new pull request #2732: HIVE-25625: Drop DummyCliDriver, TestCompareCliDriver and related code from tests
zabetak opened a new pull request #2732:
URL: https://github.com/apache/hive/pull/2732
### What changes were proposed in this pull request?
1. Drop `DummyCliDriver` and related code
2. Drop TestCompareCliDriver and related code
3. Drop unused classes/methods used from the above
### Why are the changes needed?
1. Facilitate code evolution
2. Reduce maintenance overhead
For more info check HIVE-25624 and HIVE-25625.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Mainly refactoring so no explicit tests required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak closed pull request #2732: HIVE-25625: Drop DummyCliDriver, TestCompareCliDriver and related code from tests
Posted by GitBox <gi...@apache.org>.
zabetak closed pull request #2732:
URL: https://github.com/apache/hive/pull/2732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #2732: HIVE-25625: Drop DummyCliDriver, TestCompareCliDriver and related code from tests
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #2732:
URL: https://github.com/apache/hive/pull/2732#discussion_r732868243
##########
File path: testutils/ptest2/conf/deployed/master-mr2.properties
##########
@@ -84,7 +84,7 @@ ut.itests.hive-unit.skipBatching=TestAcidOnTezWithSplitUpdate TestAcidOnTez Test
unitTests.module.itests.qtest=itests.qtest
ut.itests.qtest.batchSize=9
-ut.itests.qtest.skipBatching=TestCompareCliDriver TestContribCliDriver TestContribNegativeCliDriver TestEncryptedHDFSCliDriver TestHBaseNegativeCliDriver TestPerfCliDriver TestParseNegativeDriver
+ut.itests.qtest.skipBatching=TestContribCliDriver TestContribNegativeCliDriver TestEncryptedHDFSCliDriver TestHBaseNegativeCliDriver TestPerfCliDriver TestParseNegativeDriver
Review comment:
we don't really need to take care of this....in fact we may simply remove this `ptest` and `ptest2` directories as well...they are just dead weight (you may include the removal of them in the next cleanup ticket/or separate)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a change in pull request #2732: HIVE-25625: Drop DummyCliDriver, TestCompareCliDriver and related code from tests
Posted by GitBox <gi...@apache.org>.
zabetak commented on a change in pull request #2732:
URL: https://github.com/apache/hive/pull/2732#discussion_r733509452
##########
File path: testutils/ptest2/conf/deployed/master-mr2.properties
##########
@@ -84,7 +84,7 @@ ut.itests.hive-unit.skipBatching=TestAcidOnTezWithSplitUpdate TestAcidOnTez Test
unitTests.module.itests.qtest=itests.qtest
ut.itests.qtest.batchSize=9
-ut.itests.qtest.skipBatching=TestCompareCliDriver TestContribCliDriver TestContribNegativeCliDriver TestEncryptedHDFSCliDriver TestHBaseNegativeCliDriver TestPerfCliDriver TestParseNegativeDriver
+ut.itests.qtest.skipBatching=TestContribCliDriver TestContribNegativeCliDriver TestEncryptedHDFSCliDriver TestHBaseNegativeCliDriver TestPerfCliDriver TestParseNegativeDriver
Review comment:
I suppose ptest died when ptest2 was introduced, and ptest2 reached EOL after HIVE-22942. Is that right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #2732: HIVE-25625: Drop DummyCliDriver, TestCompareCliDriver and related code from tests
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #2732:
URL: https://github.com/apache/hive/pull/2732#discussion_r733510464
##########
File path: testutils/ptest2/conf/deployed/master-mr2.properties
##########
@@ -84,7 +84,7 @@ ut.itests.hive-unit.skipBatching=TestAcidOnTezWithSplitUpdate TestAcidOnTez Test
unitTests.module.itests.qtest=itests.qtest
ut.itests.qtest.batchSize=9
-ut.itests.qtest.skipBatching=TestCompareCliDriver TestContribCliDriver TestContribNegativeCliDriver TestEncryptedHDFSCliDriver TestHBaseNegativeCliDriver TestPerfCliDriver TestParseNegativeDriver
+ut.itests.qtest.skipBatching=TestContribCliDriver TestContribNegativeCliDriver TestEncryptedHDFSCliDriver TestHBaseNegativeCliDriver TestPerfCliDriver TestParseNegativeDriver
Review comment:
yes - exactly :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org