[GitHub] [pinot] Jackie-Jiang commented on pull request #10670: [cleanup] remove worker instance

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on PR #10670:
URL: https://github.com/apache/pinot/pull/10670#issuecomment-1518745922

   > > We should not directly use `ServerInstance` which is backed by `InstanceConfig`. Instead, we should introduce a new class which wraps the `hostname`, `controlPort` and `dataPort`
   > 
   > yes that's going to be my next PR. i can merge the 2 together if that's preferred
   
   I'd suggest making it one PR because the next one will revert the changes in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org