Re: [PR] [Opt](cloud) Notify BE to make committed rowset visible directly after txn commit without fetching from meta service [doris]

["bobhan1 (via GitHub)" <gi...@apache.org>]

bobhan1 commented on code in PR #59754:
URL: https://github.com/apache/doris/pull/59754#discussion_r2791185547


##########
be/src/agent/task_worker_pool.cpp:
##########
@@ -2387,6 +2388,53 @@ void calc_delete_bitmap_callback(CloudStorageEngine& engine, const TAgentTaskReq
     remove_task_info(req.task_type, req.signature);
 }
 
+void make_cloud_committed_rs_visible_callback(CloudStorageEngine& engine,
+                                              const TAgentTaskRequest& req) {
+    if (!config::enable_cloud_make_rs_visible_on_be) {
+        return;
+    }
+    LOG(INFO) << "begin to make cloud tmp rs visible, txn_id="
+              << req.make_cloud_tmp_rs_visible_req.txn_id
+              << ", tablet_count=" << req.make_cloud_tmp_rs_visible_req.tablet_ids.size();
+
+    const auto& make_visible_req = req.make_cloud_tmp_rs_visible_req;
+    auto& tablet_mgr = engine.tablet_mgr();
+
+    int64_t txn_id = make_visible_req.txn_id;
+    int64_t version_update_time_ms = make_visible_req.__isset.version_update_time_ms
+                                             ? make_visible_req.version_update_time_ms
+                                             : 0;
+
+    // Process each tablet involved in this transaction on this BE
+    for (int64_t tablet_id : make_visible_req.tablet_ids) {
+        auto tablet_result = tablet_mgr.get_tablet(tablet_id, false, false, nullptr, true, false);

Review Comment:
   don't need with clangd's inlay hints



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org