You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2016/04/25 15:32:07 UTC

[GitHub] flink pull request: [FLINK-3803] [runtime] Pass CheckpointStatsTra...

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/1927

    [FLINK-3803] [runtime] Pass CheckpointStatsTracker to ExecutionGraph

    `CheckpointStatsTracker` was instantiated in `ExecutionGraph#enableSnapshotCheckpointing`, where the Flink configuration is not available to parse the configuration. As a result, the configuration was not picked up at all and the default configuration was used.
    
    Instead of instantiating the `CheckpointStatsTracker` in the `ExecutionGraph` method, we directly pass it to it.
    
    I've tested this locally with a checkpointed job and verified that the configuration is picked up as expected. I would like to merge this to `master` and `release-1.0`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 3803-exec_settings

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1927.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1927
    
----
commit 512854a1aa355ccb41d0a5c8cc983d7e995ed6c7
Author: Ufuk Celebi <uc...@apache.org>
Date:   2016-04-25T13:15:47Z

    [FLINK-3803] [runtime] Pass CheckpointStatsTracker to ExecutionGraph
    
    `CheckpointStatsTracker` was instantiated in `ExecutionGraph#enableSnapshotCheckpointing`,
    where the Flink configuration is not available to parse the configuration.
    
    Instead of instantiating the `CheckpointStatsTracker` in the `ExecutionGraph`
    method, we directly pass it to it.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3803] [runtime] Pass CheckpointStatsTra...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1927


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3803] [runtime] Pass CheckpointStatsTra...

Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/1927#issuecomment-214665070
  
    Test failures are unrelated and I have two successful runs in my local Travis: https://travis-ci.org/uce/flink/builds/125561984, https://travis-ci.org/uce/flink/builds/125563304.
    
    I'm going to merge this for 1.1.0 and 1.0.3.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---