[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request, #1585: MINIFICPP-2132 improve error messages, refactor EL Value

["szaszm (via GitHub)" <gi...@apache.org>]

szaszm opened a new pull request, #1585:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1585

   The improved error message is in the `strParse` function of `Value`. It wraps number parsing functions, instead of calling them directly, and rethrows them with a friendlier message. Also, changed `RouteOnAttribute` to include the exception type.
   
   The error that started this journey:
   ```
   [2023-06-02 12:05:44.143] [org::apache::nifi::minifi::processors::RouteOnAttribute] [error] Caught exception while updating attributes: stoll (6741476a-bc4a-4196-8dd7-0e7faa7c7b3b)
   ```
   `RouteOnAttribute` was used with an expression containing `:ge()`, and the referenced flow file attributes were not numbers.
   
   ------
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [x] If applicable, have you updated the LICENSE file?
   - [x] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1585: MINIFICPP-2132 improve error messages, refactor EL Value

["fgerlits (via GitHub)" <gi...@apache.org>]

fgerlits closed pull request #1585: MINIFICPP-2132 improve error messages, refactor EL Value
URL: https://github.com/apache/nifi-minifi-cpp/pull/1585


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org