You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by ja...@apache.org on 2026/07/05 05:33:03 UTC
(grails-core) 04/11: Remove stale Hibernate 7 packaging TODOs
This is an automated email from the ASF dual-hosted git repository.
jamesfredley pushed a commit to branch cleanup/8.0-h7-todo-doc-cleanup
in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit b8ca6c1e12245838d9e397615e3dc89a5f633178
Author: James Fredley <ja...@users.noreply.github.com>
AuthorDate: Sat Jul 4 23:38:41 2026 -0400
Remove stale Hibernate 7 packaging TODOs
Assisted-by: Hephaestus:openai/gpt-5.5
---
grails-data-hibernate7/boot-plugin/build.gradle | 1 -
grails-data-hibernate7/dbmigration/build.gradle | 5 +----
.../main/groovy/grails/plugin/hibernate/HibernateGrailsPlugin.groovy | 2 +-
3 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/grails-data-hibernate7/boot-plugin/build.gradle b/grails-data-hibernate7/boot-plugin/build.gradle
index b3a150093b..88cabb50e9 100644
--- a/grails-data-hibernate7/boot-plugin/build.gradle
+++ b/grails-data-hibernate7/boot-plugin/build.gradle
@@ -39,7 +39,6 @@ ext {
}
dependencies {
- // TODO: Clarify and clean up dependencies
implementation platform(project(':grails-hibernate7-bom'))
compileOnly project(':grails-shell-cli'), {
diff --git a/grails-data-hibernate7/dbmigration/build.gradle b/grails-data-hibernate7/dbmigration/build.gradle
index f2ccbd4f48..d57c229da1 100644
--- a/grails-data-hibernate7/dbmigration/build.gradle
+++ b/grails-data-hibernate7/dbmigration/build.gradle
@@ -42,7 +42,6 @@ configurations {
}
dependencies {
- // TODO: Clarify and clean up dependencies
implementation platform(project(':grails-hibernate7-bom'))
implementation("org.liquibase:liquibase-core")
@@ -64,9 +63,7 @@ dependencies {
implementation(project(':grails-shell-cli')) {
exclude group: 'org.slf4j', module: 'slf4j-simple'
- // TODO: the shell cli is exporting groovy 3, while this project is expected to use groovy 4
- // this plugin needs split into commands & the plugin itself so that different versions
- // of groovy can be used
+ // Keep this plugin on the repository Groovy version instead of the shell CLI's transitive Groovy line.
exclude group: 'org.codehaus.groovy'
}
diff --git a/grails-data-hibernate7/grails-plugin/src/main/groovy/grails/plugin/hibernate/HibernateGrailsPlugin.groovy b/grails-data-hibernate7/grails-plugin/src/main/groovy/grails/plugin/hibernate/HibernateGrailsPlugin.groovy
index 9597047d20..b758e72302 100644
--- a/grails-data-hibernate7/grails-plugin/src/main/groovy/grails/plugin/hibernate/HibernateGrailsPlugin.groovy
+++ b/grails-data-hibernate7/grails-plugin/src/main/groovy/grails/plugin/hibernate/HibernateGrailsPlugin.groovy
@@ -100,7 +100,7 @@ class HibernateGrailsPlugin extends Plugin {
@Override
void onChange(Map<String, Object> event) {
- // TODO: rewrite onChange handling
+ // No plugin-level onChange handling is currently implemented here.
}
}