You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/23 02:22:44 UTC
[GitHub] [arrow] amoeba opened a new pull request, #13948: [MINOR]: [C++] Replace std::random_shuffle with std::shuffle
amoeba opened a new pull request, #13948:
URL: https://github.com/apache/arrow/pull/13948
`std::random_shuffle` was deprecated in C++14 and removed altogether in C++17 in favor of `std::shuffle`. The codebase only uses these shuffling functions in tests and benchmarks and `std::shuffle` is used in all instances except this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #13948: MINOR: [C++] Replace std::random_shuffle with std::shuffle
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #13948:
URL: https://github.com/apache/arrow/pull/13948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13948: [MINOR]: [C++] Replace std::random_shuffle with std::shuffle
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13948:
URL: https://github.com/apache/arrow/pull/13948#issuecomment-1223443977
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13948: MINOR: [C++] Replace std::random_shuffle with std::shuffle
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13948:
URL: https://github.com/apache/arrow/pull/13948#issuecomment-1224239371
Benchmark runs are scheduled for baseline = 8b8914719cdfd6a18158783716562249025e9e63 and contender = cc7599360133e07458aa7e07562ade5b8c419d8c. cc7599360133e07458aa7e07562ade5b8c419d8c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d7c43e4f7da146299ab8ea1a6798c645...10111007e0694c498c687ae8e4357a6d/)
[Failed :arrow_down:0.48% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/aa8b6bd2d464492dbdb748fb0ae92398...5028a68c4aa34c7892c947515a081a09/)
[Failed :arrow_down:0.82% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/097c4a3e5c654124a09bc68b3f124be6...6c9f9bf39f5c4c0eb99757d664b88b9c/)
[Finished :arrow_down:0.64% :arrow_up:0.43%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b00e9982f927499885fc53a9743fbd05...6797ae8d3b3a4d1abb66c55d568856f1/)
Buildkite builds:
[Finished] [`cc759936` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1354)
[Failed] [`cc759936` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1370)
[Failed] [`cc759936` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1352)
[Finished] [`cc759936` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1369)
[Finished] [`8b891471` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1353)
[Finished] [`8b891471` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1369)
[Failed] [`8b891471` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1351)
[Finished] [`8b891471` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1368)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13948: MINOR: [C++] Replace std::random_shuffle with std::shuffle
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13948:
URL: https://github.com/apache/arrow/pull/13948#issuecomment-1224239660
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/aa8b6bd2d464492dbdb748fb0ae92398...5028a68c4aa34c7892c947515a081a09/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/097c4a3e5c654124a09bc68b3f124be6...6c9f9bf39f5c4c0eb99757d664b88b9c/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org