[GitHub] [iceberg] nastra commented on a diff in pull request #6664: Core: Fix API breakages around scanMetrics()

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #6664:
URL: https://github.com/apache/iceberg/pull/6664#discussion_r1086909693


##########
core/src/main/java/org/apache/iceberg/SnapshotScan.java:
##########
@@ -67,8 +66,7 @@ protected Long snapshotId() {
 
   protected abstract CloseableIterable<T> doPlanFiles();
 
-  @VisibleForTesting
-  ScanMetrics scanMetrics() {
+  protected ScanMetrics scanMetrics() {

Review Comment:
   the original method in `BaseTableScan` was `protected` rather than package-private, and we also don't need `@VisibleForTesting` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org