You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "renatoh (via GitHub)" <gi...@apache.org> on 2026/09/29 11:46:35 UTC
[PR] ensure the upstream token is preserves its type and type is not set t… [solr]
renatoh opened a new pull request, #4960:
URL: https://github.com/apache/solr/pull/4960
I have noticed that all the tokens after the SGF always have the type SYNONYM.
This is caused by the ManagedSynonymGraphFilterFactory creating a synonym on itself rather than making use of the flag includeOrig for the case where we have [terma]->[terma, termb, termc]
By making use of the flag the tokens type is now preserved and it is possible to distinguish between the synonyms and the original token further down in the analyzer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] ensure original token is not set to type:SYNONYM in SGF [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4960:
URL: https://github.com/apache/solr/pull/4960#issuecomment-6192507878
@renatoh I've assigned it to myself so we don't loose it... I am trying to think about who in the space coudl review it who is active in the project... let me see what I can do.
if i don't find anyone, i'll probably merge as it appears to make sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] ensure original token is not set to type:SYNONYM in SGF [solr]
Posted by "renatoh (via GitHub)" <gi...@apache.org>.
renatoh commented on PR #4960:
URL: https://github.com/apache/solr/pull/4960#issuecomment-5927277688
@epugh Hi Eric, if you get the chance, would you mind having a look at my changes, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] ensure original token is not set to type:SYNONYM in SGF [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4960:
URL: https://github.com/apache/solr/pull/4960#issuecomment-6329191941
@renatoh okay, I think everything is good, i added the chnagelog for you ;-). Do you want this to go all the way back to Solr 9, or just Solr 10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] ensure original token is not set to type:SYNONYM in SGF [solr]
Posted by "renatoh (via GitHub)" <gi...@apache.org>.
renatoh commented on PR #4960:
URL: https://github.com/apache/solr/pull/4960#issuecomment-6335639049
@epugh I have not added the changelog since I was not sure if these changes will end up being merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] ensure original token is not set to type:SYNONYM in SGF [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4960:
URL: https://github.com/apache/solr/pull/4960#issuecomment-6338727592
Great! I have labeled it 9.x Milestone which means David Smiley's backporting tool will fire up in the next day or so and do the work to backport to there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] ensure original token is not set to type:SYNONYM in SGF [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #4960:
URL: https://github.com/apache/solr/pull/4960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] ensure original token is not set to type:SYNONYM in SGF [solr]
Posted by "renatoh (via GitHub)" <gi...@apache.org>.
renatoh commented on PR #4960:
URL: https://github.com/apache/solr/pull/4960#issuecomment-6338895166
@epugh Fantastic, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] ensure original token is not set to type:SYNONYM in SGF [solr]
Posted by "renatoh (via GitHub)" <gi...@apache.org>.
renatoh commented on PR #4960:
URL: https://github.com/apache/solr/pull/4960#issuecomment-6337931139
@epugh Please merge it also into 9.x, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org