You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/06 06:11:11 UTC
[GitHub] [incubator-inlong] LvJiancheng opened a new pull request, #4518: [INLONG-4403] [Manager] Support oracle sink
LvJiancheng opened a new pull request, #4518:
URL: https://github.com/apache/incubator-inlong/pull/4518
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-4403] [Manager] Support oracle sink
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/incubator-inlong/issues) number)*
- Fixes #4403
### Motivation
*Support oracle sink*
### Modifications
*Add Iceberg sink info and load node utils.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] LvJiancheng commented on a diff in pull request #4518: [INLONG-4403][Manager] Support Oracle sink
Posted by GitBox <gi...@apache.org>.
LvJiancheng commented on code in PR #4518:
URL: https://github.com/apache/incubator-inlong/pull/4518#discussion_r893034651
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/oracle/OracleSinkDTO.java:
##########
@@ -40,8 +43,9 @@
public class OracleSinkDTO {
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+ private static final Logger LOGGER = LoggerFactory.getLogger(MySQLSinkDTO.class);
- @ApiModelProperty("Oracle meta db URL, etc jdbc:oracle://host:port/database")
+ @ApiModelProperty("Oracle JDBC URL, such as jdbc:oracle://host:port/database")
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4518: [INLONG-4403][Manager] Support Oracle sink
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4518:
URL: https://github.com/apache/incubator-inlong/pull/4518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gong commented on a diff in pull request #4518: [INLONG-4403][Manager] Support Oracle sink
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #4518:
URL: https://github.com/apache/incubator-inlong/pull/4518#discussion_r893030793
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/oracle/OracleSinkDTO.java:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.pojo.sink.oracle;
+
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import io.swagger.annotations.ApiModelProperty;
+import lombok.AllArgsConstructor;
+import lombok.Builder;
+import lombok.Data;
+import lombok.NoArgsConstructor;
+import org.apache.inlong.manager.common.enums.ErrorCodeEnum;
+import org.apache.inlong.manager.common.exceptions.BusinessException;
+
+import javax.validation.constraints.NotNull;
+import java.util.Map;
+
+/**
+ * Oracle sink info
+ */
+@Data
+@Builder
+@NoArgsConstructor
+@AllArgsConstructor
+public class OracleSinkDTO {
+
+ private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+
+ @ApiModelProperty("Oracle meta db URL, etc jdbc:oracle://host:port/database")
+ private String jdbcUrl;
+
+ @ApiModelProperty("Username for JDBC URL")
+ private String username;
+
+ @ApiModelProperty("User password")
+ private String password;
+
+ @ApiModelProperty("Target table name")
+ private String tableName;
+
+ @ApiModelProperty("Primary key")
+ private String primaryKey;
+
+ @ApiModelProperty("Properties for Oracle")
+ private Map<String, Object> properties;
+
+ /**
+ * Get the dto instance from the request
+ */
+ public static OracleSinkDTO getFromRequest(OracleSinkRequest request) {
+ return OracleSinkDTO.builder()
+ .jdbcUrl(request.getJdbcUrl())
+ .tableName(request.getTableName())
+ .username(request.getUsername())
+ .password(request.getPassword())
+ .primaryKey(request.getPrimaryKey())
+ .properties(request.getProperties())
+ .build();
+ }
+
+ /**
+ * Get Oracle sink info from JSON string
+ */
+ public static OracleSinkDTO getFromJson(@NotNull String extParams) {
+ try {
+ OBJECT_MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
+ return OBJECT_MAPPER.readValue(extParams, OracleSinkDTO.class);
+ } catch (Exception e) {
+ throw new BusinessException(ErrorCodeEnum.SINK_INFO_INCORRECT.getMessage());
Review Comment:
print full exception stack by log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gong commented on a diff in pull request #4518: [INLONG-4403][Manager] Support Oracle sink
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #4518:
URL: https://github.com/apache/incubator-inlong/pull/4518#discussion_r893031962
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/oracle/OracleSinkDTO.java:
##########
@@ -40,8 +43,9 @@
public class OracleSinkDTO {
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+ private static final Logger LOGGER = LoggerFactory.getLogger(MySQLSinkDTO.class);
- @ApiModelProperty("Oracle meta db URL, etc jdbc:oracle://host:port/database")
+ @ApiModelProperty("Oracle JDBC URL, such as jdbc:oracle://host:port/database")
Review Comment:
jdbc url example may be error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org